You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/11/06 00:10:41 UTC
Review Request 63567: MesosTidy: Removed redundant `get()` on smart
pointers in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63567/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
```
3rdparty/libprocess/src/../include/process/owned.hpp:117:7:
warning: redundant get() call on smart pointer
[google-readability-redundant-smartptr-get]
```
Diffs
-----
3rdparty/libprocess/include/process/owned.hpp e1ae6dcc771cf2244bc16bbab19e9f05fa1704cc
3rdparty/libprocess/include/process/shared.hpp d58c885349bca279e057def0401a3bddf4d994d8
3rdparty/libprocess/src/tests/owned_tests.cpp f9f4ccef9da23d46f8764bed27c07d6a65ae061a
3rdparty/libprocess/src/tests/shared_tests.cpp 2a2ffe76b7b7ce016b559de7b5d3a28a06f422ef
Diff: https://reviews.apache.org/r/63567/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 63567: MesosTidy: Removed redundant `get()` on
smart pointers in libprocess.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63567/#review190139
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Nov. 6, 2017, 1:11 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63567/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2017, 1:11 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> ```
> 3rdparty/libprocess/src/../include/process/owned.hpp:117:7:
> warning: redundant get() call on smart pointer
> [google-readability-redundant-smartptr-get]
> ```
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/owned.hpp e1ae6dcc771cf2244bc16bbab19e9f05fa1704cc
> 3rdparty/libprocess/include/process/shared.hpp d58c885349bca279e057def0401a3bddf4d994d8
> 3rdparty/libprocess/src/tests/owned_tests.cpp f9f4ccef9da23d46f8764bed27c07d6a65ae061a
> 3rdparty/libprocess/src/tests/shared_tests.cpp 2a2ffe76b7b7ce016b559de7b5d3a28a06f422ef
>
>
> Diff: https://reviews.apache.org/r/63567/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 63567: MesosTidy: Removed redundant `get()` on
smart pointers in libprocess.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63567/
-----------------------------------------------------------
(Updated Nov. 6, 2017, 10:55 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Simply removed the redundant `get()` checks.
Repository: mesos
Description (updated)
-------
```
3rdparty/libprocess/src/../include/process/owned.hpp:117:7:
warning: redundant get() call on smart pointer
[google-readability-redundant-smartptr-get]
```
Diffs (updated)
-----
3rdparty/libprocess/include/process/owned.hpp e1ae6dcc771cf2244bc16bbab19e9f05fa1704cc
3rdparty/libprocess/include/process/shared.hpp d58c885349bca279e057def0401a3bddf4d994d8
3rdparty/libprocess/src/tests/owned_tests.cpp f9f4ccef9da23d46f8764bed27c07d6a65ae061a
3rdparty/libprocess/src/tests/shared_tests.cpp 2a2ffe76b7b7ce016b559de7b5d3a28a06f422ef
Diff: https://reviews.apache.org/r/63567/diff/2/
Changes: https://reviews.apache.org/r/63567/diff/1-2/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 63567: MesosTidy: Removed redundant `get()` on
smart pointers in libprocess.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63567/
-----------------------------------------------------------
(Updated Nov. 5, 2017, 4:11 p.m.)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
```
3rdparty/libprocess/src/../include/process/owned.hpp:117:7:
warning: redundant get() call on smart pointer
[google-readability-redundant-smartptr-get]
```
Diffs
-----
3rdparty/libprocess/include/process/owned.hpp e1ae6dcc771cf2244bc16bbab19e9f05fa1704cc
3rdparty/libprocess/include/process/shared.hpp d58c885349bca279e057def0401a3bddf4d994d8
3rdparty/libprocess/src/tests/owned_tests.cpp f9f4ccef9da23d46f8764bed27c07d6a65ae061a
3rdparty/libprocess/src/tests/shared_tests.cpp 2a2ffe76b7b7ce016b559de7b5d3a28a06f422ef
Diff: https://reviews.apache.org/r/63567/diff/1/
Testing (updated)
-------
`make check`
Thanks,
Michael Park