You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2011/10/28 12:56:32 UTC
[jira] [Created] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Remove the last dependency call from org.apache.hadoop.record package in MR.
----------------------------------------------------------------------------
Key: MAPREDUCE-3302
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
Project: Hadoop Map/Reduce
Issue Type: Task
Components: client
Affects Versions: 0.24.0
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Fix For: 0.24.0
SecureShuffleUtils provides the following helper:
{code}
/**
* verify that hash equals to HMacHash(msg)
* @param newHash
* @return true if is the same
*/
private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
byte[] msg_hash = generateByteHash(msg, key);
return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
}
{code}
The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
The {{Utils#compareBytes}} contains:
{code}
/** Lexicographic order of binary data. */
public static int compareBytes(byte[] b1, int s1, int l1,
byte[] b2, int s2, int l2) {
return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
}
{code}
Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273957#comment-13273957 ]
Harsh J commented on MAPREDUCE-3302:
------------------------------------
I consider this a trivial change as I've already noted above that the implementation call we're switching to has the exact same definition as the former. If no one has further comments, I'll commit this in by Monday.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283500#comment-13283500 ]
Hudson commented on MAPREDUCE-3302:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2307 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2307/])
MAPREDUCE-3302. Remove the last dependency call from org.apache.hadoop.record package in MR. (harsh) (Revision 1342613)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342613
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/SecureShuffleUtils.java
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283983#comment-13283983 ]
Hudson commented on MAPREDUCE-3302:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #1091 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1091/])
MAPREDUCE-3302. Remove the last dependency call from org.apache.hadoop.record package in MR. (harsh) (Revision 1342613)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342613
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/SecureShuffleUtils.java
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
Per parent JIRA, recordio is still in use apparently. Resolving as won't fix.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283440#comment-13283440 ]
Hudson commented on MAPREDUCE-3302:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #2288 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2288/])
MAPREDUCE-3302. Remove the last dependency call from org.apache.hadoop.record package in MR. (harsh) (Revision 1342613)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342613
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/SecureShuffleUtils.java
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283961#comment-13283961 ]
Hudson commented on MAPREDUCE-3302:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #1057 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1057/])
MAPREDUCE-3302. Remove the last dependency call from org.apache.hadoop.record package in MR. (harsh) (Revision 1342613)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342613
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/SecureShuffleUtils.java
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283428#comment-13283428 ]
Hudson commented on MAPREDUCE-3302:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2361 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2361/])
MAPREDUCE-3302. Remove the last dependency call from org.apache.hadoop.record package in MR. (harsh) (Revision 1342613)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342613
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/security/SecureShuffleUtils.java
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Fix Version/s: (was: 0.24.0)
Target Version/s: 0.23.1
Status: Patch Available (was: Reopened)
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Target Version/s: (was: 3.0.0)
Status: Resolved (was: Patch Available)
Committed revision 1342613 to trunk.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Attachment: MAPREDUCE-3302.patch
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138342#comment-13138342 ]
Harsh J commented on MAPREDUCE-3302:
------------------------------------
{code}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{code}
The patch provides mere inlining of code to remove a deprecated function call, since the deprecated package is going away. {{WritableComparator#compareBytes}} is otherwise well tested already by existing tests.
Hence, no test case is specifically required for this change.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Target Version/s: 3.0.0 (was: 2.0.0-alpha, 3.0.0)
Affects Version/s: (was: 0.24.0)
3.0.0
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Issue Type: Improvement (was: Task)
Changing type to Improvement (earlier: Task).
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: client
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reopened MAPREDUCE-3302:
--------------------------------
Actually, this can and should go in anyway. Its the only one using the wrong API.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-3302:
-------------------------------
Status: Patch Available (was: Open)
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138232#comment-13138232 ]
Hadoop QA commented on MAPREDUCE-3302:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501270/MAPREDUCE-3302.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1190//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1190//console
This message is automatically generated.
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3302) Remove the last dependency call
from org.apache.hadoop.record package in MR.
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated MAPREDUCE-3302:
-------------------------------------------
Target Version/s: 2.0.0, 3.0.0 (was: 0.23.1)
> Remove the last dependency call from org.apache.hadoop.record package in MR.
> ----------------------------------------------------------------------------
>
> Key: MAPREDUCE-3302
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3302
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: client
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: MAPREDUCE-3302.patch
>
>
> SecureShuffleUtils provides the following helper:
> {code}
> /**
> * verify that hash equals to HMacHash(msg)
> * @param newHash
> * @return true if is the same
> */
> private static boolean verifyHash(byte[] hash, byte[] msg, SecretKey key) {
> byte[] msg_hash = generateByteHash(msg, key);
> return Utils.compareBytes(msg_hash, 0, msg_hash.length, hash, 0, hash.length) == 0;
> }
> {code}
> The {{Utils}} class used there is {{org.apache.hadoop.record.Utils}}. With the {{record}} common package going away via HADOOP-7781, the internal (and also deprecated on the whole) {{compareBytes}} utility must be moved elsewhere.
> The {{Utils#compareBytes}} contains:
> {code}
> /** Lexicographic order of binary data. */
> public static int compareBytes(byte[] b1, int s1, int l1,
> byte[] b2, int s2, int l2) {
> return WritableComparator.compareBytes(b1, s1, l1, b2, s2, l2);
> }
> {code}
> Which looks like it can be replaced inline, as it appears to be a dummy wrapper call. I'll put up a patch with this inline replacement shortly for review.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira