You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "yzeng1618 (via GitHub)" <gi...@apache.org> on 2026/08/26 09:28:00 UTC
[PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
yzeng1618 opened a new pull request, #11971:
URL: https://github.com/apache/seatunnel/pull/11971
### Purpose of this pull request
Fix #11969 (same root cause as the historical report #8329).
When a JDBC source table is defined by `query` only, the schema is derived from JDBC `ResultSetMetaData`, which carries no column/table comments, constraint keys or partition keys. Sinks that auto-create tables (Doris, StarRocks, MySQL, ...) therefore create tables without any comments.
This PR resolves the underlying physical table from the query result metadata when the query maps to a single table (e.g. `SELECT * FROM db.table`), and merges the missing metadata (column/table comments, primary key, constraint keys, partition keys, table options) into the query-derived table by reusing the existing `mergeCatalogTable` logic — the same behavior as configuring `table_path` together with `query`.
The merge is defensive:
- Applied in both the catalog path and the no-catalog fallback path, only when the underlying table can be resolved and exists with a non-empty schema;
- Columns renamed or transformed in the query keep the query-derived definition (`mergeCatalogTable` guards by column name + SqlType);
- Any failure loading the underlying table falls back to the current query-derived behavior.
### Does this PR introduce _any_ user-facing change?
Yes. When a JDBC source uses `query` without `table_path` and the query maps to a single existing table, the produced catalog table now carries the comments / primary key / constraint keys / partition keys of that table, so sinks with auto table creation preserve them; previously they were silently lost. The Jdbc source documentation (en/zh) is updated accordingly.
### How was this patch tested?
- New unit tests in `JdbcCatalogUtilsTest` covering: resolvable single-table query (metadata merged), unresolvable table name, database/schema missing, underlying table not existing, underlying table with empty schema, and loader failure fallback.
- Extended `JdbcMysqlTableOptionsIT`, whose job config is exactly a query-only MySQL-to-MySQL auto-create scenario: the source table now declares column comments and a table comment, and the IT asserts they are present in `SHOW CREATE TABLE` of the auto-created sink table.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6266779417
The CI fact cited in my previous review has changed: Build for the current unchanged head is now passing. CI was previously the only remaining blocker, and I do not see a new source-side blocker from Daniel's review. GitHub now reports this branch as having merge conflicts with dev. Please sync with the latest dev and resolve the conflicts first, then rerun the required checks. This merge-state blocker is separate from the now-green Build result. I have read-only review controls, so this COMMENT does not change GitHub's displayed review decision; a write-capable maintainer must perform any final approval or dismissal action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6118935373
> Thanks for keeping the branch in sync. Since the change between `6907e2f2f8fb` and `e1d06f9021c7` looks like a merge from `dev` only, I'd like to confirm the status of the earlier points rather than assume they're closed:
>
> * **PR11971-F1** – Can you confirm `YashanDbCatalog` no longer closes the shared cached connection when checking for a single-physical-table query?
> * **PR11971-F2 / PR11971-F7** – Do the OceanBase/YashanDB overrides now bound the probe query (e.g. a row limit) and reuse a single `ResultSetMetaData`, and does the default catalog path avoid executing the user query twice?
> * **PR11971-F3** – Does `mergeWithUnderlyingTable` now load the metadata-verified origin `TablePath` rather than the query-derived identifier?
> * **PR11971-F4** – For drivers that report only a schema and no catalog, does the resolved `TablePath` still end up with a null database name? If so, `tableExists`/`getTable` would throw and the merge would silently fall back. Could you either handle the schema-only case explicitly or point me to where it is covered?
> * **PR11971-F5** – Is there a changelog entry describing `query_table_metadata_merge` and its `COMMENT` default? If not, please add one.
> * **PR11971-F6** – With `ALL`, query-only pipelines gain a merged primary key on upgrade, which affects split planning and sink auto-create DDL. Are the incompatible-changes notes updated for this? Alternatively, if `COMMENT` is intentionally the only behavior applied without opt-in, please state that explicitly in the docs.
> * **PR11971-F8** – Are fallback failures now logged at a visible level instead of being swallowed at `DEBUG`?
>
> A quick pointer to the relevant lines for each would be enough. Once those are confirmed I'm happy to do a final pass.
Verified at `e1d06f9021c7`:
- **PR11971-F1** — Resolved. `YashanDbCatalog.resolveQueryTable` closes only the `Statement` and `ResultSet`; the shared cached `Connection` remains open. See [YashanDbCatalog.java#L199-L241](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/yashandb/YashanDbCatalog.java#L199-L241).
- **PR11971-F2 / PR11971-F7** — Resolved. Both dialect overrides use `setMaxRows(1)` and a single `ResultSetMetaData` for origin verification. The default `AbstractJdbcCatalog` path uses `PreparedStatement.getMetaData()`, so the user query is not executed a second time. See [OceanBaseMySqlCatalog.java#L222-L282](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/oceanbase/OceanBaseMySqlCatalog.java#L222-L282), [YashanDbCatalog.java#L199-L241](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/yashandb/YashanDbCatalog.java#L199-L241), and [AbstractJdbcCatalog.java#L700-L718](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/Abstrac
tJdbcCatalog.java#L700-L718).
- **PR11971-F3** — Resolved. `mergeWithUnderlyingTable` receives the metadata-verified `singlePhysicalTablePath` separately from the query-derived table and uses the verified path when loading the underlying table. The regression test also uses different query and origin paths. See [JdbcCatalogUtils.java#L549-L583](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java#L549-L583) and [JdbcCatalogUtilsTest.java#L674-L692](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtilsTest.java#L674-L692).
- **PR11971-F4** — The catalog-backed path handles schema-only metadata through `withDefaultDatabase`, filling the database from the configured default before calling `tableExists/getTable`. The direct JDBC metadata fallback does not call `tableExists/getTable`; it loads metadata through `CatalogUtils.getCatalogTable`. Tests cover missing database, existing database, and the no-default-database case. See [JdbcCatalogUtils.java#L282-L300](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java#L282-L300), [JdbcCatalogUtils.java#L500-L536](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java#L500-L536), and [JdbcCatalogUtilsTest.java#L785-L808](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-co
nnectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtilsTest.java#L785-L808).
- **PR11971-F5** — Yes. `query_table_metadata_merge` and its `COMMENT` default are documented in both English and Chinese JDBC documentation. The behavior is also documented in both incompatible-changes documents. See [Jdbc.md#L50](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/docs/en/connectors/source/Jdbc.md#L50), [Jdbc.md#L166](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/docs/en/connectors/source/Jdbc.md#L166), and [incompatible-changes.md#L51-L67](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/docs/en/introduction/concepts/incompatible-changes.md#L51-L67).
- **PR11971-F6** — The default `COMMENT` mode only merges comments. Primary keys, constraints, partition keys, and table options remain unchanged by default. `ALL` is an explicit opt-in and its impact on sink DDL, insert/upsert behavior, and split planning is documented.
- **PR11971-F8** — Metadata verification failures and underlying-table loading failures are logged at `WARN` with the table path and exception before falling back to the query-derived table. See [AbstractJdbcCatalog.java#L710-L718](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java#L710-L718) and [JdbcCatalogUtils.java#L575-L583](https://github.com/yzeng1618/seatunnel-dev/blob/e1d06f9021c7/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcCatalogUtils.java#L575-L583). The remaining `DEBUG` log in YashanDB is only for optional primary-key enrichment.
All eight points are covered at the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5595119138
<img width="1076" height="194" alt="image" src="https://github.com/user-attachments/assets/7021932d-c642-4e5c-9bf4-74b5476ee562" />
Please solve conflicts~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "SEZ9 (via GitHub)" <gi...@apache.org>.
SEZ9 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6118215355
Thanks for keeping the branch in sync. Since the change between `6907e2f2f8fb` and `e1d06f9021c7` looks like a merge from `dev` only, I'd like to confirm the status of the earlier points rather than assume they're closed:
- **PR11971-F1** – Can you confirm `YashanDbCatalog` no longer closes the shared cached connection when checking for a single-physical-table query?
- **PR11971-F2 / PR11971-F7** – Do the OceanBase/YashanDB overrides now bound the probe query (e.g. a row limit) and reuse a single `ResultSetMetaData`, and does the default catalog path avoid executing the user query twice?
- **PR11971-F3** – Does `mergeWithUnderlyingTable` now load the metadata-verified origin `TablePath` rather than the query-derived identifier?
- **PR11971-F4** – For drivers that report only a schema and no catalog, does the resolved `TablePath` still end up with a null database name? If so, `tableExists`/`getTable` would throw and the merge would silently fall back. Could you either handle the schema-only case explicitly or point me to where it is covered?
- **PR11971-F5** – Is there a changelog entry describing `query_table_metadata_merge` and its `COMMENT` default? If not, please add one.
- **PR11971-F6** – With `ALL`, query-only pipelines gain a merged primary key on upgrade, which affects split planning and sink auto-create DDL. Are the incompatible-changes notes updated for this? Alternatively, if `COMMENT` is intentionally the only behavior applied without opt-in, please state that explicitly in the docs.
- **PR11971-F8** – Are fallback failures now logged at a visible level instead of being swallowed at `DEBUG`?
A quick pointer to the relevant lines for each would be enough. Once those are confirmed I'm happy to do a final pass.
<!-- streview-comment:1697 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx commented on code in PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#discussion_r4324614780
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java:
##########
@@ -95,6 +95,7 @@ JdbcSourceOptions.TABLE_LIST, new TableListExclusiveValidator()))
JdbcSourceOptions.STRING_SPLIT_MODE_COLLATE,
JdbcSourceOptions.PROPERTIES,
JdbcSourceOptions.QUERY,
+ JdbcSourceOptions.QUERY_TABLE_METADATA_MERGE,
Review Comment:
What kind of behavior will be generated when configuring both `TABLE_PATH` and `QUERY_TABLE_MTADATA_MERGE` at the same time, and are they mutually exclusive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "SEZ9 (via GitHub)" <gi...@apache.org>.
SEZ9 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6307988357
Summarizing the earlier review points so they're easy to track:
**High**
- **F1 – `YashanDbCatalog.isSinglePhysicalTableQuery` closes the shared cached connection.** The connection from `getConnection(defaultUrl)` is cached by the catalog, so closing it poisons the cache and the new merge step can't succeed for YashanDB. Please avoid closing the cached connection (or use a dedicated connection for this probe).
- **F2 – OceanBase/YashanDB overrides run the full user query just to read metadata.** Please bound the query (e.g. a row limit) so large tables can't cause long stalls or OOM during planning.
**Medium**
- **F3 – verified origin `TablePath` is discarded.** The merge should use the `TablePath` actually verified from metadata rather than whatever path the query-derived `TableIdentifier` carries; otherwise PK/comments can be merged from the wrong table.
- **F4 – schema-only drivers produce a null database name.** `tableExists`/`getTable` throws in that case and the merge silently never applies. Please handle the null-database case explicitly.
- **F7 – query prepared/executed twice on the catalog path.** The no-catalog path already reuses a single `ResultSetMetaData`; please align the catalog path with it.
- **F8 – fallbacks swallow exceptions at DEBUG.** Since the merge is an advertised feature, please log fallbacks at WARN with the reason so users can diagnose why metadata wasn't preserved.
**Docs / compatibility**
- **F5 / F6 – changelog and `incompatible-changes.md`.** Query-only pipelines gain a merged primary key on upgrade, which changes split planning and sink auto-create DDL. Please record this in the incompatible-changes notes alongside the `Jdbc.md` changes.
Happy to take another pass once these are addressed. Thanks!
<!-- streview-comment:1922 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on code in PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#discussion_r4331841818
##########
docs/zh/connectors/source/Jdbc.md:
##########
@@ -157,6 +159,7 @@ driver = "org.mariadb.jdbc.Driver"
| username | String | 否 | - | 数据库账号。历史配置键 `user` 仍作为兼容键支持。 |
| password | String | 否 | - | 数据库账号的密码。 |
| query | String | 否 | - | 要执行的 SQL。需要同时明确表身份和元数据时,可以与 `table_path` 组合使用。 |
+| query_table_metadata_merge | Enum | 否 | COMMENT | 仅配置 `query` 的源表合并底表元数据的范围(仅在查询被验证为映射到单张物理表时生效)。`COMMENT` 仅合并字段注释和表注释;`ALL` 额外合并表选项、主键、约束键和分区键——效果等同于同时配置 `table_path` 与 `query`,可能改变 Sink 建表 DDL,使配置了 `generate_sink_sql` 的 Sink 从 insert 切换为 upsert,并启用基于主键的切分规划;`NONE` 完全跳过底表解析。也可以在 `table_list` 中按表单独配置。 |
Review Comment:
Thanks @nzw921rx, fair challenge, and let me be precise about what the default does today and correct my own wording.
**What the default does (head `4d4a6ecfc`):** `JdbcSourceOptions.QUERY_TABLE_METADATA_MERGE` defaults to `COMMENT` (`JdbcSourceOptions.java`, the new option), and `JdbcCatalogUtils.metadataMergeMode(...)` falls back to that default when the entry has no explicit value (`JdbcCatalogUtils.java:296-300`). So an unconfigured query-only source does take the new path (`:277-294`): it probes the query's result metadata, resolves the single underlying table, and merges only column comments and the table comment (`mergeComments`, `:594-623`). It keeps the query-derived identity, options, primary key, constraint keys and partition keys, so split planning, insert/upsert choice and row shape do not change.
**Where it is not identical to the old behavior for unconfigured users:**
- Auto-creating sinks (MySQL, Doris, StarRocks, ...) will now create target tables with the source column and table comments on the first run after upgrade (already-created sink tables are untouched). That is the intended user benefit, but it is a visible difference.
- Planning does one extra metadata probe plus a `tableExists`/`getTable` per query-only table; any failure logs a WARN and falls back to the query-derived table (`:549-590`).
- In my last review I called the PR "fully compatible". The more accurate phrase is "documented, low-risk behavior change by default"; the PR documents it in the `incompatible-changes.md` entry (en and zh). Sorry for the loose wording.
**Your options, from smallest to largest change:** (a) keep `COMMENT` and rely on the documented note, or (b) change the default to `NONE` so unconfigured jobs are byte-for-byte unchanged and the feature becomes opt-in. If you want (b), it is small: the option default (`JdbcSourceOptions`), the enum/option Javadoc that says "This is the default", the default column and prose in en/zh `Jdbc.md`, the `incompatible-changes.md` entry (it would become "new opt-in option"), and the tests that assert the default mode. The `metadataMergeMode(...)` fallback already reads `defaultValue()`, so no logic change is needed. The trade-off is that users with query-only sources only get comments after setting `query_table_metadata_merge = COMMENT`. Since SeaTunnel's guidance is not to change defaults casually, I would support (b) if that is the project's rule; it is your call as maintainer and I will re-review whichever way @yzeng1618 goes.
Separate from this: GitHub currently reports this branch as conflicting with `dev` (`mergeable_state: dirty`), so it needs a sync before it can merge.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/JdbcSourceFactory.java:
##########
@@ -95,6 +95,7 @@ JdbcSourceOptions.TABLE_LIST, new TableListExclusiveValidator()))
JdbcSourceOptions.STRING_SPLIT_MODE_COLLATE,
JdbcSourceOptions.PROPERTIES,
JdbcSourceOptions.QUERY,
+ JdbcSourceOptions.QUERY_TABLE_METADATA_MERGE,
Review Comment:
Good question. Short answer: they are **not** mutually exclusive in validation, but they do not combine; `table_path` wins and `query_table_metadata_merge` is not consulted.
Trace (catalog path, `JdbcCatalogUtils.getCatalogTable(tableConfig, jdbcCatalog, jdbcDialect)`):
- `table_path` and `query` both set (`JdbcCatalogUtils.java:246-270`): this is the pre-existing branch. It loads the table from `table_path`, runs the query for the query-derived table, and calls `mergeCatalogTable(tableOfPath, tableOfQuery)`, i.e. the full merge (the same result that `ALL` produces). It never reads `getQueryTableMetadataMerge()`.
- `table_path` only (`:272-275`): plain `jdbcCatalog.getTable(tablePath)`; the mode is not consulted.
- query only (`:277-294`): the only branch that reads `metadataMergeMode(tableConfig)`: `NONE` returns the old `jdbcCatalog.getTable(query)`, otherwise `resolveQueryTable` plus `mergeWithUnderlyingTable`.
The direct-connection fallback has the same shape (`:474-499` for `table_path` + `query`, `:508-518` for query only).
The factory does not declare any exclusivity between them either: `JdbcSourceFactory.optionRule()` lists `TABLE_PATH`, `QUERY` and `QUERY_TABLE_METADATA_MERGE` as plain optionals (the only exclusivity rule is the `table_list` validator), and the `Jdbc.md` docs say `query` can be combined with `table_path`.
Consequence worth deciding: a config with `table_path` + `query` + `query_table_metadata_merge = NONE` still gets the full merge, and the option is silently ignored. That is consistent with the option description ("derived from a query-only source table"), but it can surprise someone who sets `NONE` expecting the old behavior. Two small options: document explicitly in en/zh `Jdbc.md` that the option only applies when `table_path` is not set, or log a WARN (or reject) when it is explicitly set together with `table_path`. I would put this at Low severity and leave the choice to you and @yzeng1618; a one-line doc sentence plus a unit test pinning that `table_path` + `query` ignores the mode would be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx commented on code in PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#discussion_r4324545651
##########
docs/zh/connectors/source/Jdbc.md:
##########
@@ -157,6 +159,7 @@ driver = "org.mariadb.jdbc.Driver"
| username | String | 否 | - | 数据库账号。历史配置键 `user` 仍作为兼容键支持。 |
| password | String | 否 | - | 数据库账号的密码。 |
| query | String | 否 | - | 要执行的 SQL。需要同时明确表身份和元数据时,可以与 `table_path` 组合使用。 |
+| query_table_metadata_merge | Enum | 否 | COMMENT | 仅配置 `query` 的源表合并底表元数据的范围(仅在查询被验证为映射到单张物理表时生效)。`COMMENT` 仅合并字段注释和表注释;`ALL` 额外合并表选项、主键、约束键和分区键——效果等同于同时配置 `table_path` 与 `query`,可能改变 Sink 建表 DDL,使配置了 `generate_sink_sql` 的 Sink 从 insert 切换为 upsert,并启用基于主键的切分规划;`NONE` 完全跳过底表解析。也可以在 `table_list` 中按表单独配置。 |
Review Comment:
default is NONE?
Maintain the old behavior for unconfigured users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5459099244
Thanks for the thorough follow-up review, @SEZ9 — this is a genuinely useful second pass on top of mine.
Issue 1 (YashanDB `isSinglePhysicalTableQuery` closing the shared cached connection via try-with-resources on `getConnection(defaultUrl)`) is a real catch I missed in both of my rounds. I only checked that the *pattern* mirrored `AbstractJdbcCatalog.isSinglePhysicalTableQuery`/`OceanBaseMySqlCatalog`'s "don't close the shared connection" convention at a glance, not that `YashanDbCatalog` actually followed it — it doesn't, and closing the cached `defaultUrl` connection poisons the connection map for every later `tableExists`/`getTable` call on that catalog instance, not just this new code path. Agreed this is a High-severity blocker.
On Issue 2 (OceanBase/YashanDB executing the full query a second time): this overlaps with my own Issue 2/recommended-fix from the previous round — I had it as a doubled-execution cost/side-effect concern and kept it non-blocking since it degrades to "slower, not wrong." Your framing (no `setMaxRows`/row cap on an arbitrary user query, so a `SELECT * FROM huge_table` can buffer client-side and OOM at planning time) is the sharper and more production-relevant version of the same root cause, and combined with Issue 1 landing in the same connection-handling code, I agree this should move to a blocker alongside Issue 1 rather than stay a fast-follow.
Issues 3 and 4 (verified origin `TablePath` discarded in favor of the query-derived `TableIdentifier`'s path, and null database name for schema-only dialects swallowing into a silent `tableExists` failure) are both new findings I didn't trace — the TablePath-divergence one in particular is a correctness gap worth closing before merge, not just a follow-up, since it can attach the wrong table's PK/constraints under a same-named-table-in-another-schema collision.
Issues 5/6 (incompatible-changes.md) match what I flagged as Medium/non-blocking last round — no disagreement there, just confirming alignment so @yzeng1618 doesn't need to reconcile two separate asks.
Issue 7 is the same double-execution root cause as Issue 2 / my prior finding — agreed, one fix should close both.
Issue 8 (DEBUG-level swallowing on every fallback path) is a fair catch given how much silent-failure surface this PR just added; I'd raise at least the loader-failure branch to `warn` with the table path included.
@yzeng1618 — given Issue 1 and Issue 2 are now assessed as blocking (connection-pool poisoning plus an unbounded second execution on the same code path), please fold the fixes for those together with Issues 3/4/7/8 in the next commit. I'll hold off on a fresh full review until that lands, then re-review the whole diff against the new head rather than just the delta, since the connection-handling fix may touch the same lines as the double-execution fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "SEZ9 (via GitHub)" <gi...@apache.org>.
SEZ9 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5611938710
@DanielLeens thanks for tracing the history on this re-review round — that is exactly the information I needed. Your diff of `bbb76bd99a` against the pre-merge head, restricted to `connector-jdbc`, `Jdbc.md` and `incompatible-changes.md`, showing zero changes to this PR's own files, tells me the new head is a pure conflict-resolution merge. I agree it does not warrant a fresh code re-review on its own, and I also saw your follow-up that the `Build` check on `bbb76bd99a` has completed successfully with no new commits since.
One consequence of that, though: because the merge did not touch any PR files, the state of the findings from my earlier review is exactly what it was at `6bafd798fc`. Nothing in this thread tells me which of them were addressed before that head, so before I give the write-side approval I need a short status per item:
- **PR11971-F1 (HIGH)** – `YashanDbCatalog.isSinglePhysicalTableQuery` closing the shared cached connection from `getConnection(defaultUrl)`, which poisons the catalog connection cache and makes the merge step always fail for YashanDB.
- **PR11971-F2 (HIGH)** – the OceanBase/YashanDB overrides executing the full user query with no row limit just to read metadata.
- **PR11971-F3 / F4 (MEDIUM)** – in `JdbcCatalogUtils`, the metadata-verified origin `TablePath` being discarded in favour of whatever the query-derived `TableIdentifier` carries, and the null database name for schema-only drivers causing `tableExists`/`getTable` to throw so the merge silently never applies.
- **PR11971-F5 / F6 (MEDIUM)** – the changelog and `incompatible-changes.md` entries for the automatic metadata merge and the newly merged primary key on upgrade. You mention `incompatible-changes.md` is among the PR's files, so if it now covers this, a pointer is enough.
- **PR11971-F7 / F8 (MEDIUM)** – the catalog path preparing/executing the query twice, and all fallback paths swallowing exceptions at DEBUG level.
If these were resolved in commits leading up to `6bafd798fc`, a quick "fixed in …" per item (or "not fixed, here is why") is all I need; I will then re-check only those spots rather than re-auditing the PR. If any are still open, F1 and F2 are the ones I consider blocking, the rest can be argued either way.
Thanks again for the careful work on the re-review scope — it made this round much easier.
<!-- streview-comment:940 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5433590676
Addressed the review findings in commit 281fe76d1:
- Validate every result column's catalog/schema/table before merging underlying-table metadata. Detected joins, inconsistent origins, and missing origin metadata now keep the query-derived table unchanged.
- Apply the guard to both catalog-backed and direct JDBC fallback paths, including the Statement-based metadata paths used by OceanBase and YashanDB.
- Add the requested UnderlyingTableLoader Javadoc and link the EN/ZH documentation to the existing query primary-key caution.
- Add regression coverage for same-table metadata, a multi-table JOIN result, and skipping the metadata loader for multi-table queries.
Validation:
- .\mvnw.cmd -o spotless:apply
- .\mvnw.cmd -o -pl seatunnel-connectors-v2/connector-jdbc -Dskip.spotless=true -Dcheckstyle.skip=true -Dtest=CatalogUtilsTest,JdbcCatalogUtilsTest test (32 tests, 0 failures, 0 errors)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5713031546
Thanks for tracking this down and posting the direct evidence, @yzeng1618 — that lines up exactly with what I found in my last review round: the `updated-modules-integration-test-part-4` failure is `OpengaussCDCIT#testAddFieldWithRestore`, a module this PR never touches.
I independently checked #12344 and #12346: #12344 is open and confirms the same failure reproducing 40/40 times across two unrelated PRs (#12298, #12299) and two base commits, so this is a genuine `dev`-baseline flake, not something introduced by #11971. #12346 (the proposed fix) is also still open/unmerged, so there is nothing to sync against yet.
Agreed on the plan: keep this PR focused and do not fold the CDC fix in here. Once #12346 (or whatever supersedes it) lands on `dev`, sync this branch and rerun `Build` — I would expect it to go green given this PR's own code, the `connector-jdbc` unit tests, and `JdbcMysqlTableOptionsIT` (7/7) are already passing on the current head (`6907e2f2f8fb`).
No code blockers remain on my side; this is purely a CI-green gate plus final maintainer approval at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6409456517
Thank you @nzw921rx for the real-database test matrix and @DanielLeens for re-verifying everything against the current head — both reviews are now addressed in `a89a3e35cf`. Point-by-point:
**P1: `ALL` one-sided-join cardinality.** Agreed that the origin check cannot see the FROM/JOIN shape, and rejecting all such queries would also reject true single-table queries (indistinguishable in `ResultSetMetaData`). Chosen boundary: `ALL` is now explicitly a *user-asserted* mode — a WARN is logged at merge time (documenting the one-sided-join hazard and its upsert-collapsing consequence), the option/enum Javadoc, en/zh `Jdbc.md` and `incompatible-changes.md` all state it, and `testAllModeMergesOneSidedJoinOriginPerUserAssertion` pins the behavior as deliberate so any future change to the semantics is a visible diff. `COMMENT`/`NONE` do not merge keys and stay safe for such queries.
**P1: Driver support boundary.** With your (and Daniel's) endorsement of the smaller scope, the feature now documents its per-driver support matrix instead of claiming generic support: MySQL family supported (verified on real databases); PostgreSQL (table-only origin, no catalog/schema), Oracle/SQL Server/DuckDB (blank origin table name) documented as "use `table_path` + `query`" with a note that SQL Server/DuckDB catalogs do not expose the table comment. The matrix is in en/zh `Jdbc.md` and summarized in `incompatible-changes.md`; the option description and `getPhysicalTablePath` contract Javadoc state the same boundary.
**P1: SAP HANA mapping.** `SapHanaCatalog` now overrides `resolveQueryTable` to return the query-derived table with an empty verified origin path, with Javadoc explaining the databaseName-as-schema mapping mismatch — the merge is explicitly disabled for HANA until the namespace mapping is aligned (and it remains real-test-required before re-enabling), so a query on `TEST.T` can no longer load `SYSTEM.T`.
**Issue 9: helper contract.** `CatalogUtils.getPhysicalTablePath` now carries a contract Javadoc: null on missing table identity, blank catalog/schema normalized to null, and dialect default/mapping is the caller's responsibility.
**P2: branch state.** The branch was synced with `dev` on 2026-10-25 (conflict resolved in the OceanBase import section only); GitHub now reports the PR as MERGEABLE. Your review was against `4d4a6ecf`, which predates the sync and the two subsequent fix commits (`4a08829d5` default `NONE` + docs; `a89a3e35cf` this round).
Left as documented future work (not silently dropped): dialect-aware origin resolution for PostgreSQL/Oracle/SQL Server/DuckDB with real-driver-family ITs, HANA namespace alignment, and re-visiting whether `ALL` can gain a structural join guard. CI for `a89a3e35cf` is running; I'll keep the branch green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5707921389
### CI failure note: unrelated OpenGauss CDC regression on `dev`
The current `updated-modules-integration-test-part-4` failures are not caused by this PR's JDBC query-only metadata changes. Both JDK legs fail in the existing `OpengaussCDCIT#testAddFieldWithRestore` test with the same assertion:
```text
actual iterable was <null> at index [1][4]
```
Failed jobs:
- JDK 8: https://github.com/yzeng1618/seatunnel-dev/actions/runs/35062794202/job/104790155477
- JDK 11: https://github.com/yzeng1618/seatunnel-dev/actions/runs/35062794202/job/104790155543
The job log confirms that the live five-column schema is replaced by the four-column checkpoint schema during restore:
```text
restore before: ROW<id INT,f_bytea BYTES,f_small SMALLINT,f_int INT,f_big BIGINT>
restore after: ROW<id INT,f_bytea BYTES,f_small SMALLINT,f_int INT>
```
The first restored CDC record still contains `f_big=2147483647`, but `RestoreTableSchemaEvent` rebuilds the JDBC writer with a four-column INSERT, leaving the sink's `f_big` value as `NULL`.
This is tracked as a `dev` baseline regression in #12344. That issue reports the same failure in unrelated Zeta PRs #12298 and #12299, reproducing 40/40 times across two base commits and both JDK 8 and JDK 11. This PR does not modify OpenGauss CDC, the CDC restore path, or `AbstractJdbcSinkWriter`.
Existing fixes are being discussed in #12321 and #12346. In particular, #12346's corresponding part-4 jobs have already passed on both JDK 8 and JDK 11. To keep #11971 focused, I do not plan to mix the unrelated CDC fix into this PR. Once the upstream fix is merged into `dev`, I will sync the branch and rerun the failed checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6359805371
Thanks @nzw921rx for running this against real databases and for the detailed matrix. This is exactly the evidence the mocked `ResultSetMetaData` unit tests cannot give us. I did not run the databases myself (my check is static, nothing was executed locally); I re-read the code on head `4d4a6ecfca20` to see whether your findings line up with it, and they do.
**P1 PostgreSQL / Oracle / SQL Server / DuckDB no-op.** Consistent with the code. `CatalogUtils.getSinglePhysicalTablePath` / `getPhysicalTablePath` (connector-jdbc `CatalogUtils.java:345-382`) returns empty as soon as `ResultSetMetaData.getTableName` is blank, which matches your Oracle / SQL Server / DuckDB result. For PostgreSQL, where the table name is reported but catalog and schema are blank, `JdbcCatalogUtils.mergeWithUnderlyingTable` returns `tableOfQuery` early when both database and schema are blank (the `isBlank(getDatabaseName) && isBlank(getSchemaName)` guard). So for these drivers the `COMMENT` default silently does nothing, and the docs (`Jdbc.md:50`) currently describe the behavior generically without saying which database families actually resolve a table.
**P1 `ALL` with a one-sided join.** Also consistent. The only guard is "every result column reports the same origin table", so `SELECT t.* FROM t JOIN t2 ...` passes it, and `ALL` would then merge `t`'s primary key and options even though the join can multiply rows. `Jdbc.md:50` says the merge is skipped for "detected multi-table queries", but nothing detects this shape. `COMMENT` stays safe, which supports keeping it as the default.
**P1 SAP HANA and MySQL-only real-DB coverage.** I agree these need an owner decision; the HANA schema-vs-database mapping in particular should not ship untested.
Suggested next steps for @yzeng1618 (the branch needs a rebase anyway, see below):
1. Decide the scope. Either make the PostgreSQL case work (fill the default schema/database from the catalog before the blank-both early return, plus a `JdbcPostgresIT` query-only case), or document explicitly that the feature currently resolves MySQL-family drivers only.
2. For Oracle / SQL Server / DuckDB, either require `table_path` and say so in the docs, or resolve the table another way; do not rely on `ResultSetMetaData.getTableName`.
3. For `ALL`, add a join guard (or at least a documented warning plus a join test). Keep `COMMENT` as the default.
4. Add a per-database support matrix for `query_table_metadata_merge` to the docs, and either a HANA-specific override or a HANA-specific test.
5. Rebase on current `dev`: GitHub reports `mergeable_state: dirty` (head ahead 12, behind 101 versus `dev`), so the conflicts need resolving and CI needs to run on the new head.
I have not pushed any verdict on top of your change request. Once a new head is pushed I will do a full fresh pass over the whole diff against the points above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6338505715
Thanks @SEZ9. I checked your F1-F8 summary against `4d4a6ecf`, because these have changed from the earlier implementation:
- **F1/F2:** `YashanDbCatalog.resolveQueryTable` keeps the cached connection outside try-with-resources (206), caps returned rows with setMaxRows(1) (208), and closes the statement/result set only. OceanBaseMySqlCatalog does the same at 234-243. A returned-row cap does not promise that the database avoids all expensive query planning/scanning, but neither path now materializes an unbounded result just to consume metadata.
- **F3/F4/F7:** `JdbcCatalogUtils.java:281-293` consumes one QueryTableResolution, loads its verified physical path, and fills a blank database through `withDefaultDatabase` (526-531). It does not discard that path and reconstruct it from the query-derived identifier. The existing unit cases around 668 and 787 pin verified-origin and default-database handling.
- **F8:** verification fallback WARN is at `AbstractJdbcCatalog.java:710-711`; load fallback WARN is at `JdbcCatalogUtils.java:580`. These are not DEBUG-only on this head.
- **F5/F6:** EN Jdbc.md:50/166 and incompatible-changes.md:150 onward document that COMMENT is the default, preserving primary keys/options/constraints/partition keys, while ALL is explicit opt-in. The ZH mirrors document the same. Therefore unconditional new primary-key inference is not the default behavior of the final implementation. The PR description still contains the older broad merge description and would benefit from being aligned with COMMENT versus ALL; that is not evidence the old implementation is still running.
My prior note about table_path plus query taking precedence over the query-only mode remains a non-blocking scope clarification. This reply does not close your review on your behalf or constitute another full code review. Build is green, but GitHub now reports conflicts against dev. Please resolve those conflicts and rerun checks on the new head; the full updated diff and final write-capable maintainer review will then need a fresh pass.
Current status evidence: head `4d4a6ecfca200e39e2d489d1b233bba2948f027d`, base `dev`, compare `diverged` (ahead 12, behind 87), mergeable state `dirty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-5617127216
@SEZ9 Status per item, verified against the source at `9e057517bf54` (the commit that closed all eight findings) and re-confirmed unchanged through the current head `bbb76bd99a`, which, as you noted, touches none of this PR's own files:
- **F1** (YashanDB closing the shared cached connection) — fixed. `YashanDbCatalog.resolveQueryTable` keeps `getConnection(defaultUrl)` outside the try-with-resources, with only the `Statement` inside it, plus a Javadoc note that the connection is cached/shared and must not be closed there. Confirmed present at the current head.
- **F2** (unbounded second query execution) — fixed. The old two-call shape (`getTable` plus a separate `isSinglePhysicalTableQuery`) was replaced with a single `resolveQueryTable` that OceanBase and YashanDB each override once, so the query now executes exactly once, capped with `setMaxRows(1)`. One residual, already-disclosed caveat I'm carrying as a non-blocking Medium follow-up, not fixed by this PR: `setMaxRows(1)` bounds the client-side result but may not stop a MySQL-protocol driver from buffering the full server-side result before truncating.
- **F3/F4** (verified origin TablePath discarded / null database name) — fixed. `mergeWithUnderlyingTable` now takes the verified `Optional<TablePath>` from `resolveQueryTable` directly instead of re-deriving one from the query's `TableIdentifier`, and `JdbcCatalogUtils.withDefaultDatabase` fills in a missing database name from the catalog default before the `tableExists`/`getTable` lookup.
- **F5/F6** (incompatible-changes.md) — fixed. Both `docs/en` and `docs/zh` `incompatible-changes.md` gained a JDBC Connector entry covering the merge behavior, the split-planning implication, and the workaround.
- **F7/F8** (double execution / debug-level swallowing) — fixed. Same root cause as F2 (now one execution), and every fallback catch in `resolveQueryTable`/`getSinglePhysicalTablePath`/`mergeWithUnderlyingTable` logs at warn with the table path and exception instead of debug.
All eight were re-traced against the raw diff at the time, not taken on the author's word: see my 2026-08-31 review for the itemized verification against `9e057517bf54`, and my 2026-09-09 re-review for the re-confirmation on a later head. Since this PR's files haven't changed since, the status above still holds on `bbb76bd99a`.
From my side there's no open blocker. The one thing I'd still like closed as a fast-follow, not a merge blocker, is confirming whether `setMaxRows(1)` actually limits server-side transfer for the OceanBase driver. I have read-only rights here, so once you're satisfied a write-capable maintainer can take it from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Preserve table metadata for JDBC source in query-only mode [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11971:
URL: https://github.com/apache/seatunnel/pull/11971#issuecomment-6473890968
Thanks for the contribution. The merge-gate fact cited in my previous conclusion has changed: GitHub now reports a real merge conflict. This follow-up corrects that gate on the unchanged reviewed head; it is not another full source review or a sync request based only on being behind.
Gate snapshot (2026-10-28T15:57:39+00:00), head `a89a3e35cf620e64feba069964a23e9b3d33a438`: [Build](https://github.com/apache/seatunnel/runs/121424833630) is `FAILURE`.
The blocking jobs are [Run / updated-modules-integration-test-part-8 (11, ubuntu-latest)](https://github.com/yzeng1618/seatunnel-dev/actions/runs/40277985038/job/121426714797) `failure`.
The failed job list is observed, but its causal error is not established by the available summary. Please inspect the linked failed step/report before choosing a source change; no verified upstream sync-only cure is established in this follow-up.
My [previous source conclusion](https://github.com/apache/seatunnel/pull/11971#pullrequestreview-5649159150) remains clear for the reviewed scope. CI is not being passed by inference, and this follow-up is not an effective approval.
Separately, GitHub reports merge conflicts with `dev`. Please sync the latest base and resolve the conflicts first; the resulting new head needs checks and re-review. This conflict gate is independent of CI and existing source findings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org