You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/11/19 19:33:04 UTC

[GitHub] [sling-org-apache-sling-testing-osgi-mock] stefanseifert commented on pull request #13: SLING-10930 don't automatically call deactivate method

stefanseifert commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/13#issuecomment-974356131


   i would rather keep this deactivation - maybe resources are closed there which otherwise may leak or block other tests.
   if there is an edge case calling this multiple times, probably we can fix this easily, e.g. recording a set of impl classes during shutdown where we already called the deactivate method, and not calling it again on those.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org