[GitHub] [spark] HyukjinKwon commented on a change in pull request #24437: [SPARK-27512][SQL] Avoid to replace ', ' in CSV's decimal type inference for backward compatibility

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #24437: [SPARK-27512][SQL] Avoid to replace ',' in CSV's decimal type inference for backward compatibility
URL: https://github.com/apache/spark/pull/24437#discussion_r277340110
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchema.scala
 ##########
 @@ -32,7 +34,10 @@ class CSVInferSchema(val options: CSVOptions) extends Serializable {
     options.zoneId,
     options.locale)
 
-  private val decimalParser = {
+  private val decimalParser = if (options.locale == Locale.US) {
 
 Review comment:
   Yes.. we gotta do that I think .. Let's do that later when we drop the replacement thing entirely. I realised that CSV inference path alone handles it without replacement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org