You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/03/16 18:34:57 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1972: Add specific types for Fate locks and Zoo locks
ctubbsii commented on a change in pull request #1972:
URL: https://github.com/apache/accumulo/pull/1972#discussion_r595442560
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -106,11 +119,11 @@ public ZooLock(AccumuloConfiguration conf, String path, UUID uuid) {
}
}
- protected ZooLock(ZooKeeper zookeeper, String path, UUID uuid) {
+ protected ZooLock(ZooKeeper zookeeper, ZooLockPath path, UUID uuid) {
Review comment:
If the `toString()` is correct, then that line is correct. Java automatically calls `toString()` on non-null objects when doing string concatenation (and uses literal "null" if null).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org