You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/09/28 11:14:03 UTC
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16511
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
HIVE-24145 still causes data load failures quite frequently. The failure
usually occurs during TPC-DS loading. I modified
generate-schema-statements.py to only load ORC tables as full ACID in
the 'functional-query' workload. Since this workload contains the
ACID-specific tests, we should still have enough coverage for ORC/ACID
testing.
Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
---
M testdata/bin/generate-schema-statements.py
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/16511/1
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6476/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2020 11:14:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6481/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 08:31:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/7298/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2020 14:46:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 13:51:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7295/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2020 11:35:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16511
to look at the new patch set (#3).
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
HIVE-24145 still causes data load failures quite frequently. The failure
usually occurs during TPC-DS loading. I modified
generate-schema-statements.py to only load ORC tables as full ACID in
the 'functional-query' workload. Since this workload contains the
ACID-specific tests, we should still have enough coverage for ORC/ACID
testing.
Testing
* Ran exhaustive tests successfully
Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
---
M testdata/bin/generate-schema-statements.py
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
2 files changed, 21 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/16511/3
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 08:31:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2020 14:51:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6476/
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Sep 2020 16:28:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16511
to look at the new patch set (#2).
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
HIVE-24145 still causes data load failures quite frequently. The failure
usually occurs during TPC-DS loading. I modified
generate-schema-statements.py to only load ORC tables as full ACID in
the 'functional-query' workload. Since this workload contains the
ACID-specific tests, we should still have enough coverage for ORC/ACID
testing.
Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
---
M testdata/bin/generate-schema-statements.py
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
2 files changed, 21 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/16511/2
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
HIVE-24145 still causes data load failures quite frequently. The failure
usually occurs during TPC-DS loading. I modified
generate-schema-statements.py to only load ORC tables as full ACID in
the 'functional-query' workload. Since this workload contains the
ACID-specific tests, we should still have enough coverage for ORC/ACID
testing.
Testing
* Ran exhaustive tests successfully
Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Reviewed-on: http://gerrit.cloudera.org:8080/16511
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/bin/generate-schema-statements.py
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
2 files changed, 21 insertions(+), 15 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16511 )
Change subject: IMPALA-9923: Load ORC files as full ACID only in workload 'functional-query'
......................................................................
Patch Set 3: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/16511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c81aedd3be314819dc4bc5bebec17bad3d03b10
Gerrit-Change-Number: 16511
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 08:31:37 +0000
Gerrit-HasComments: No