You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Dekrate (via GitHub)" <gi...@apache.org> on 2025/12/10 18:04:56 UTC
[PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Dekrate opened a new pull request, #20340:
URL: https://github.com/apache/camel/pull/20340
# Description
This PR upgrades the JBang version used in the test infrastructure (specifically camel-test-infra-cli) and
camel-jbang-core export tests from 4.8.3 to 4.16.0.
The tests were previously pinned to an older version. Updating them ensures that the integration tests (IT) and export
commands are verified against a more recent version of Camel JBang (4.16.0), keeping the test infrastructure aligned
with the project's current state.
Changes include:
- Updating hardcoded version strings in CliConfigITCase.java and RunITCase.java.
- Updating expected versions in ExportTest.java.
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
@davsclaus <- it was your task
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #20340:
URL: https://github.com/apache/camel/pull/20340#discussion_r2608066654
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/it/CliConfigITCase.java:
##########
@@ -49,7 +49,7 @@ public void setCamelVersionTest() {
}
@Test
- @SetSystemProperty(key = "cli.service.version", value = "4.8.3")
+ @SetSystemProperty(key = "cli.service.version", value = "4.16.0")
@SetSystemProperty(key = "cli.service.execute.version", value = "4.8.0")
Review Comment:
I think this 4.8.0 should also be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Posted by "Dekrate (via GitHub)" <gi...@apache.org>.
Dekrate commented on code in PR #20340:
URL: https://github.com/apache/camel/pull/20340#discussion_r2609783393
##########
test-infra/camel-test-infra-cli/src/test/java/org/apache/camel/test/infra/cli/it/CliConfigITCase.java:
##########
@@ -49,7 +49,7 @@ public void setCamelVersionTest() {
}
@Test
- @SetSystemProperty(key = "cli.service.version", value = "4.8.3")
+ @SetSystemProperty(key = "cli.service.version", value = "4.16.0")
@SetSystemProperty(key = "cli.service.execute.version", value = "4.8.0")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20340:
URL: https://github.com/apache/camel/pull/20340#issuecomment-3638336377
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Posted by "Dekrate (via GitHub)" <gi...@apache.org>.
Dekrate commented on PR #20340:
URL: https://github.com/apache/camel/pull/20340#issuecomment-3641224422
I investigated the git history of `MinaUdpNoCamelTest.java`. It appears the file was migrated during the
`camel-mina2` to `camel-mina` renaming/cleanup back in 2019 (commit `fdd8fc5`), likely carried over from the legacy
`camel-mina2` component.
Given that:
1. It is a standalone test for the Mina library itself, with no dependency on Camel logic ("NoCamel").
2. It has been a source of flakiness on CI (especially s390x) due to the unreliable nature of UDP packet delivery and test environments.
3. It does not provide value for validating the Camel Mina component integration. I agree with the suggestion to remove it entirely instead of attempting to patch the flakiness. I will proceed with
deleting the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-22771: camel-jbang - Upgrade test infra to use JBang 4.16.0 [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #20340:
URL: https://github.com/apache/camel/pull/20340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org