You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/04/14 19:54:42 UTC

Review Request 46216: GEODE-1226: Adding a flag to prompt for a password if required

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46216/
-----------------------------------------------------------

Review request for geode, Anthony Baker, Mark Bretl, and Nitin Lamba.


Repository: geode


Description
-------

The signArchives and uploadArchives tasks require a passwords to work.
Adding a flag to request a password prompt to fill in a password.

./gradlew uploadArchives -Paskpass

This will pop up a swing dialog box asking for passwords to sign and
upload archives.

This is not on by default because we don't want developers to have to
enter a password for every build. The build target depends on
signArchives but normally will skip it if the password property is not
set.


Diffs
-----

  buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy PRE-CREATION 
  gradle/publish.gradle 02b0e3c75b5f2bdb5b3260dba6cd17e3794847e0 

Diff: https://reviews.apache.org/r/46216/diff/


Testing
-------


Thanks,

Dan Smith

Re: Review Request 46216: GEODE-1226: Adding a flag to prompt for a password if required

Posted by Anthony Baker <ab...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46216/#review128940
-----------------------------------------------------------


Ship it!




Ship It!

- Anthony Baker


On April 14, 2016, 5:54 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46216/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 5:54 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Mark Bretl, and Nitin Lamba.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The signArchives and uploadArchives tasks require a passwords to work.
> Adding a flag to request a password prompt to fill in a password.
> 
> ./gradlew uploadArchives -Paskpass
> 
> This will pop up a swing dialog box asking for passwords to sign and
> upload archives.
> 
> This is not on by default because we don't want developers to have to
> enter a password for every build. The build target depends on
> signArchives but normally will skip it if the password property is not
> set.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy PRE-CREATION 
>   gradle/publish.gradle 02b0e3c75b5f2bdb5b3260dba6cd17e3794847e0 
> 
> Diff: https://reviews.apache.org/r/46216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 46216: GEODE-1226: Adding a flag to prompt for a password if required

Posted by Dan Smith <ds...@pivotal.io>.


> On April 14, 2016, 6:27 p.m., Nitin Lamba wrote:
> > Just curious: what happens if someone enters wrong passwords? May want to add logic to abort after a set number of retries.

If you enter a wrong password, it signing the archives and uploading the artifacts will just fail and the build will fail.


- Dan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46216/#review128943
-----------------------------------------------------------


On April 14, 2016, 5:54 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46216/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 5:54 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Mark Bretl, and Nitin Lamba.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The signArchives and uploadArchives tasks require a passwords to work.
> Adding a flag to request a password prompt to fill in a password.
> 
> ./gradlew uploadArchives -Paskpass
> 
> This will pop up a swing dialog box asking for passwords to sign and
> upload archives.
> 
> This is not on by default because we don't want developers to have to
> enter a password for every build. The build target depends on
> signArchives but normally will skip it if the password property is not
> set.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy PRE-CREATION 
>   gradle/publish.gradle 02b0e3c75b5f2bdb5b3260dba6cd17e3794847e0 
> 
> Diff: https://reviews.apache.org/r/46216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Re: Review Request 46216: GEODE-1226: Adding a flag to prompt for a password if required

Posted by Nitin Lamba <nl...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46216/#review128943
-----------------------------------------------------------


Ship it!




Just curious: what happens if someone enters wrong passwords? May want to add logic to abort after a set number of retries.

- Nitin Lamba


On April 14, 2016, 5:54 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46216/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 5:54 p.m.)
> 
> 
> Review request for geode, Anthony Baker, Mark Bretl, and Nitin Lamba.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> The signArchives and uploadArchives tasks require a passwords to work.
> Adding a flag to request a password prompt to fill in a password.
> 
> ./gradlew uploadArchives -Paskpass
> 
> This will pop up a swing dialog box asking for passwords to sign and
> upload archives.
> 
> This is not on by default because we don't want developers to have to
> enter a password for every build. The build target depends on
> signArchives but normally will skip it if the password property is not
> set.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy PRE-CREATION 
>   gradle/publish.gradle 02b0e3c75b5f2bdb5b3260dba6cd17e3794847e0 
> 
> Diff: https://reviews.apache.org/r/46216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>