You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "anmolnar (via GitHub)" <gi...@apache.org> on 2024/02/05 14:32:27 UTC

[PR] ZOOKEEPER-4236 Java Client SendThread create many unnecessary Login objects [zookeeper]

anmolnar opened a new pull request, #2128:
URL: https://github.com/apache/zookeeper/pull/2128

   Move Login thread up one level to SendThread, instead of re-creating it every time a new ZooKeeperSaslClient is needed. This will avoid bombarding the KDC server with login request when the server is unavailable. It would be nice to back off in the client as well as suggested in [ZOOKEEPER-2869](https://issues.apache.org/jira/browse/ZOOKEEPER-2869).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4236 Java Client SendThread create many unnecessary Login objects [zookeeper]

Posted by "anmolnar (via GitHub)" <gi...@apache.org>.
anmolnar commented on PR #2128:
URL: https://github.com/apache/zookeeper/pull/2128#issuecomment-1927512080

   > Since we use AtomicReference for creating / destroying Login instances, this patch will resolve [ZOOKEEPER-4235](https://issues.apache.org/jira/browse/ZOOKEEPER-4235) too.
   
   I'm not 100% sure about this part, need to take a closer look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ZOOKEEPER-4236 Java Client SendThread create many unnecessary Login objects [zookeeper]

Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #2128:
URL: https://github.com/apache/zookeeper/pull/2128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org