[GitHub] [skywalking] kylixs commented on pull request #4858: support class cache for ByteBuddy

[GitBox <gi...@apache.org>]

kylixs commented on PR #4858:
URL: https://github.com/apache/skywalking/pull/4858#issuecomment-1233689565

   > > @wu-sheng If other agent do not enhance the class during the first load (transform), the class will be enhanced during the second transform. Then skywalking directly returns the byte stream cached for the first time in the second time, will it overwrite the content enhanced for the second time by other agents? Because the order in which the transform is executed depends on the order in which the Agent is configured.
   > 
   > I think this feature (class cache) only solve the conflict of skywalking and other agent which do not modify the origin class logic. If we use other agent to enable hotswap, it will not work well.
   
   Class cache is not a perfect solution. This can be a problem if another agent loads before the Skywalking agent. When retransform the same class a second time, the result of the first retransform is used. Cause the agent Retransform result before Skywalking to be overwritten. Functions such as hot-loading class will not be available. 
   This problem can be completely solved by improving ByteBuddy or replacing bytecode tools such as Arthas's ByteKit. I want to do something for it, it might take a while.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org