[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5338: [SegmentGeneratorConfig Cleanup] Refactor CreateSegmentCommand and remove the clone constructor in SegmentGeneratorConfig

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-pinot/pull/5338#discussion_r421017638



##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/io/PinotOutputFormat.java
##########
@@ -171,12 +160,10 @@ private void initSegmentConfig(JobContext context)
       throws IOException {
     _segmentConfig.setFormat(FileFormat.JSON);

Review comment:
       This class has multiple things missing. Will clean them up in the following PRs. Next step is to clean up all the empty constructors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org