You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2017/02/23 05:04:54 UTC
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Dimitris Tsirogiannis has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6124
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Testing:
Passed private verify-impala-toolchain-package-build job.
Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
---
M buildall.sh
A source/flatbuffers/build.sh
2 files changed, 41 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/24/6124/1
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Testing:
Passed private verify-impala-toolchain-package-build job.
Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
---
M buildall.sh
A source/flatbuffers/build.sh
2 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Dimitris Tsirogiannis: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
Patch Set 2:
gah, this wasn't submitted so gerrit/master and upstream/master are out of sync now (we don't have branch syncing set up on native-toolchain)
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6124
to look at the new patch set (#2).
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Testing:
Passed private verify-impala-toolchain-package-build job.
Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
---
M buildall.sh
A source/flatbuffers/build.sh
2 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/24/6124/2
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6124/1/buildall.sh
File buildall.sh:
Line 252:
remove extra blank line
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
Patch Set 2: Code-Review+2
Keep Henry's +2
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4966: Add flatbuffers 1.6.0 to toolchain
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6124/1/buildall.sh
File buildall.sh:
Line 252:
> remove extra blank line
Done
--
To view, visit http://gerrit.cloudera.org:8080/6124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17e01dd9703d2519bb1985f0246c38e6f2f57b92
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes