You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Andrey Pokhilko <ap...@ya.ru> on 2014/09/26 12:37:32 UTC
Enable saving thread counts by default?
Hi team,
Since I started developing JMeter plugins I faced one issue and after
five years it is still the most frequent request from users: "why JTL
does not contain active threads info?". Five years I've been answering
that they should put
jmeter.save.saveservice.thread_counts=true in their jmeter.properties.
It is obvious that recording current level of active threads is very
important for JMeter. Every analysis session starts from looking at
active threads dynamics. Maybe it's time to enable it by default for
everyone? It will just add couple more columns to CSV JTL.
--
Andrey Pokhilko
Re: Enable saving thread counts by default?
Posted by Philippe Mouawad <ph...@gmail.com>.
On Sat, Sep 27, 2014 at 1:33 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> Thanks Philippe,
>
> Now I'm able to see the failure. Do we have bugzilla for the change
> already or should I register one?
>
Create one mentionning the 2 discussions.
Thanks
>
> Andrey Pokhilko
>
> On 09/27/2014 02:16 PM, Philippe Mouawad wrote:
> > Hello,
> > It's because there was an issue in last commit which upgraded serializer
> > version to 2.7.2, one test was failing.
> >
> > Try again now, you will see.
> > Regards
> >
> > On Sat, Sep 27, 2014 at 1:00 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> >
> >> Hi,
> >>
> >> I took latest trunk from SVN and changed bin/jmeter.properties to have
> >> jmeter.save.saveservice.thread_counts=true
> >>
> >> Then I ran "ant clean download_jars install test". The only error that
> >> showed is:
> >> [java] There was 1 failure:
> >> [java] 1)
> >>
> >>
> testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.ComparisonFailure:
> >> serializer expected:<2.7.[2]> but was:<2.7.[1]>
> >> [java] at
> >>
> org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:182)
> >> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> >> Method)
> >> [java] at
> >>
> >>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> >> [java] at
> >>
> >>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >> [java] at
> org.apache.jorphan.test.AllTests.main(AllTests.java:236)
> >>
> >> Which seems to be unrelated to saveservice change. It also appears
> >> without any change to properties.
> >>
> >> So I see no tests failing after the change. Does it mean that we can do
> >> the change right now?
> >>
> >> Andrey Pokhilko
> >>
> >> On 09/26/2014 04:24 PM, UBIK LOAD PACK Support wrote:
> >>> Hi,
> >>> Answering on behalf of Philippe as we had some discussion on this.
> >>>
> >>> What you can do is make the change and run the Ant task called "test".
> >>> properties used by test are located in
> >> bin/testfiles/jmetertest.properties.
> >>> You will get tests failures because all generated files will have an
> >>> additional field (threads) , as some test compare result files with
> >>> expected result files, they will logically fail.
> >>> So nothing complex in the change just some work to do to fix either the
> >>> test results or the properties used by test.
> >>> Maybe this can be discussed here with PMC.
> >>>
> >>> Regards
> >>>
> >>> On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> >>>
> >>>> Thanks for the link, Philippe.
> >>>>
> >>>> What prevents this change from being done? Is there really complex
> tests
> >>>> that break on this change? How can I help? (I'm not familiar with
> >>>> JMeter's source tests, unfortunately).
> >>>>
> >>>> Andrey Pokhilko
> >>>>
> >>>> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
> >>>>> Hi Andrey,
> >>>>> This has been discussed in a previous thread, see:
> >>>>>
> >>
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
> >>>>> I think it is agreed upon by PMC members, changing this just breaks
> >> some
> >>>>> Tests that need to be fixed.
> >>>>>
> >>>>>
> >>>>>
> >>
> >
>
>
--
Cordialement.
Philippe Mouawad.
Re: Enable saving thread counts by default?
Posted by Andrey Pokhilko <ap...@ya.ru>.
Thanks Philippe,
Now I'm able to see the failure. Do we have bugzilla for the change
already or should I register one?
Andrey Pokhilko
On 09/27/2014 02:16 PM, Philippe Mouawad wrote:
> Hello,
> It's because there was an issue in last commit which upgraded serializer
> version to 2.7.2, one test was failing.
>
> Try again now, you will see.
> Regards
>
> On Sat, Sep 27, 2014 at 1:00 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
>
>> Hi,
>>
>> I took latest trunk from SVN and changed bin/jmeter.properties to have
>> jmeter.save.saveservice.thread_counts=true
>>
>> Then I ran "ant clean download_jars install test". The only error that
>> showed is:
>> [java] There was 1 failure:
>> [java] 1)
>>
>> testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.ComparisonFailure:
>> serializer expected:<2.7.[2]> but was:<2.7.[1]>
>> [java] at
>> org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:182)
>> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
>> Method)
>> [java] at
>>
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>> [java] at
>>
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> [java] at org.apache.jorphan.test.AllTests.main(AllTests.java:236)
>>
>> Which seems to be unrelated to saveservice change. It also appears
>> without any change to properties.
>>
>> So I see no tests failing after the change. Does it mean that we can do
>> the change right now?
>>
>> Andrey Pokhilko
>>
>> On 09/26/2014 04:24 PM, UBIK LOAD PACK Support wrote:
>>> Hi,
>>> Answering on behalf of Philippe as we had some discussion on this.
>>>
>>> What you can do is make the change and run the Ant task called "test".
>>> properties used by test are located in
>> bin/testfiles/jmetertest.properties.
>>> You will get tests failures because all generated files will have an
>>> additional field (threads) , as some test compare result files with
>>> expected result files, they will logically fail.
>>> So nothing complex in the change just some work to do to fix either the
>>> test results or the properties used by test.
>>> Maybe this can be discussed here with PMC.
>>>
>>> Regards
>>>
>>> On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
>>>
>>>> Thanks for the link, Philippe.
>>>>
>>>> What prevents this change from being done? Is there really complex tests
>>>> that break on this change? How can I help? (I'm not familiar with
>>>> JMeter's source tests, unfortunately).
>>>>
>>>> Andrey Pokhilko
>>>>
>>>> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
>>>>> Hi Andrey,
>>>>> This has been discussed in a previous thread, see:
>>>>>
>> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
>>>>> I think it is agreed upon by PMC members, changing this just breaks
>> some
>>>>> Tests that need to be fixed.
>>>>>
>>>>>
>>>>>
>>
>
Re: Enable saving thread counts by default?
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
It's because there was an issue in last commit which upgraded serializer
version to 2.7.2, one test was failing.
Try again now, you will see.
Regards
On Sat, Sep 27, 2014 at 1:00 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> Hi,
>
> I took latest trunk from SVN and changed bin/jmeter.properties to have
> jmeter.save.saveservice.thread_counts=true
>
> Then I ran "ant clean download_jars install test". The only error that
> showed is:
> [java] There was 1 failure:
> [java] 1)
>
> testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.ComparisonFailure:
> serializer expected:<2.7.[2]> but was:<2.7.[1]>
> [java] at
> org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:182)
> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> [java] at
>
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> [java] at
>
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [java] at org.apache.jorphan.test.AllTests.main(AllTests.java:236)
>
> Which seems to be unrelated to saveservice change. It also appears
> without any change to properties.
>
> So I see no tests failing after the change. Does it mean that we can do
> the change right now?
>
> Andrey Pokhilko
>
> On 09/26/2014 04:24 PM, UBIK LOAD PACK Support wrote:
> > Hi,
> > Answering on behalf of Philippe as we had some discussion on this.
> >
> > What you can do is make the change and run the Ant task called "test".
> > properties used by test are located in
> bin/testfiles/jmetertest.properties.
> >
> > You will get tests failures because all generated files will have an
> > additional field (threads) , as some test compare result files with
> > expected result files, they will logically fail.
> > So nothing complex in the change just some work to do to fix either the
> > test results or the properties used by test.
> > Maybe this can be discussed here with PMC.
> >
> > Regards
> >
> > On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> >
> >> Thanks for the link, Philippe.
> >>
> >> What prevents this change from being done? Is there really complex tests
> >> that break on this change? How can I help? (I'm not familiar with
> >> JMeter's source tests, unfortunately).
> >>
> >> Andrey Pokhilko
> >>
> >> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
> >>> Hi Andrey,
> >>> This has been discussed in a previous thread, see:
> >>>
> >>
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
> >>> I think it is agreed upon by PMC members, changing this just breaks
> some
> >>> Tests that need to be fixed.
> >>>
> >>>
> >>>
> >>
> >
>
>
--
Cordialement.
Philippe Mouawad.
Re: Enable saving thread counts by default?
Posted by Andrey Pokhilko <ap...@ya.ru>.
Hi,
I took latest trunk from SVN and changed bin/jmeter.properties to have
jmeter.save.saveservice.thread_counts=true
Then I ran "ant clean download_jars install test". The only error that
showed is:
[java] There was 1 failure:
[java] 1)
testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.ComparisonFailure:
serializer expected:<2.7.[2]> but was:<2.7.[1]>
[java] at
org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:182)
[java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
[java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
[java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[java] at org.apache.jorphan.test.AllTests.main(AllTests.java:236)
Which seems to be unrelated to saveservice change. It also appears
without any change to properties.
So I see no tests failing after the change. Does it mean that we can do
the change right now?
Andrey Pokhilko
On 09/26/2014 04:24 PM, UBIK LOAD PACK Support wrote:
> Hi,
> Answering on behalf of Philippe as we had some discussion on this.
>
> What you can do is make the change and run the Ant task called "test".
> properties used by test are located in bin/testfiles/jmetertest.properties.
>
> You will get tests failures because all generated files will have an
> additional field (threads) , as some test compare result files with
> expected result files, they will logically fail.
> So nothing complex in the change just some work to do to fix either the
> test results or the properties used by test.
> Maybe this can be discussed here with PMC.
>
> Regards
>
> On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
>
>> Thanks for the link, Philippe.
>>
>> What prevents this change from being done? Is there really complex tests
>> that break on this change? How can I help? (I'm not familiar with
>> JMeter's source tests, unfortunately).
>>
>> Andrey Pokhilko
>>
>> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
>>> Hi Andrey,
>>> This has been discussed in a previous thread, see:
>>>
>> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
>>> I think it is agreed upon by PMC members, changing this just breaks some
>>> Tests that need to be fixed.
>>>
>>>
>>>
>>
>
Re: Enable saving thread counts by default?
Posted by UBIK LOAD PACK Support <su...@ubikloadpack.com>.
Hi,
Answering on behalf of Philippe as we had some discussion on this.
What you can do is make the change and run the Ant task called "test".
properties used by test are located in bin/testfiles/jmetertest.properties.
You will get tests failures because all generated files will have an
additional field (threads) , as some test compare result files with
expected result files, they will logically fail.
So nothing complex in the change just some work to do to fix either the
test results or the properties used by test.
Maybe this can be discussed here with PMC.
Regards
On Fri, Sep 26, 2014 at 3:18 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> Thanks for the link, Philippe.
>
> What prevents this change from being done? Is there really complex tests
> that break on this change? How can I help? (I'm not familiar with
> JMeter's source tests, unfortunately).
>
> Andrey Pokhilko
>
> On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
> > Hi Andrey,
> > This has been discussed in a previous thread, see:
> >
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
> >
> > I think it is agreed upon by PMC members, changing this just breaks some
> > Tests that need to be fixed.
> >
> >
> >
>
>
--
Regards
Ubik Load Pack <http://ubikloadpack.com> Team
Follow us on Twitter <http://twitter.com/ubikloadpack>
Cordialement
L'équipe Ubik Load Pack <http://ubikloadpack.com>
Suivez-nous sur Twitter <http://twitter.com/ubikloadpack>
Re: Enable saving thread counts by default?
Posted by Andrey Pokhilko <ap...@ya.ru>.
Thanks for the link, Philippe.
What prevents this change from being done? Is there really complex tests
that break on this change? How can I help? (I'm not familiar with
JMeter's source tests, unfortunately).
Andrey Pokhilko
On 09/26/2014 02:05 PM, Philippe Mouawad wrote:
> Hi Andrey,
> This has been discussed in a previous thread, see:
> http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
>
> I think it is agreed upon by PMC members, changing this just breaks some
> Tests that need to be fixed.
>
>
>
Re: Enable saving thread counts by default?
Posted by Philippe Mouawad <p....@ubik-ingenierie.com>.
Hi Andrey,
This has been discussed in a previous thread, see:
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201404.mbox/%3CCAOGo0VaiM=TdW_Fj9fE1De4W8jao8ox5ELTAFVHTyN=5SY0d+Q@mail.gmail.com%3E
I think it is agreed upon by PMC members, changing this just breaks some
Tests that need to be fixed.
--
Regards.
Philippe M.
Ubik-Ingénierie
UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/>
UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>
On Fri, Sep 26, 2014 at 12:37 PM, Andrey Pokhilko <ap...@ya.ru> wrote:
> Hi team,
>
> Since I started developing JMeter plugins I faced one issue and after
> five years it is still the most frequent request from users: "why JTL
> does not contain active threads info?". Five years I've been answering
> that they should put
> jmeter.save.saveservice.thread_counts=true in their jmeter.properties.
>
> It is obvious that recording current level of active threads is very
> important for JMeter. Every analysis session starts from looking at
> active threads dynamics. Maybe it's time to enable it by default for
> everyone? It will just add couple more columns to CSV JTL.
>
> --
> Andrey Pokhilko
>
>
<http://twitter.com/ubikloadpack>