You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/10/21 04:29:16 UTC
[GitHub] [incubator-ratis] amaliujia opened a new pull request #229: RATIS-1101. Fix Failed UT: RaftBasicTests.runTestOldLeaderNotCommit:IndexOutOfBounds
amaliujia opened a new pull request #229:
URL: https://github.com/apache/incubator-ratis/pull/229
## What changes were proposed in this pull request?
Seeing a flaky instance of `RaftBasicTests.runTestOldLeaderNotCommit` due to `IndexOutOfBounds` (https://github.com/apache/incubator-ratis/pull/225/checks?check_run_id=1281324912).
The exception is from
```
for (int i = 1; i < NUM_SERVERS - 1; i++) {
RaftServerImpl follower = followers.get(i);
cluster.killServer(follower.getId());
}
```
where it turned out i exceeded the range of followers size. This might be due to slow machine/process so followers are not enough.
Per suggestion from @szetszwo we can use `org.junit.AssumptionViolatedException` to not fail this test in this special case.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1101
## How was this patch tested?
UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #229: RATIS-1101. Fix Failed UT: RaftBasicTests.runTestOldLeaderNotCommit:IndexOutOfBounds
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #229:
URL: https://github.com/apache/incubator-ratis/pull/229#issuecomment-713296638
R: @szetszwo can you take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo merged pull request #229: RATIS-1101. Fix Failed UT: RaftBasicTests.runTestOldLeaderNotCommit:IndexOutOfBounds
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #229:
URL: https://github.com/apache/incubator-ratis/pull/229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org