You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/09 18:41:39 UTC

[GitHub] [arrow] jonkeane commented on a diff in pull request #13105: ARROW-16511: [R] Preserve schema metadata in write_dataset()

jonkeane commented on code in PR #13105:
URL: https://github.com/apache/arrow/pull/13105#discussion_r868315177


##########
r/R/dataset-write.R:
##########
@@ -206,9 +206,13 @@ write_dataset <- function(dataset,
   validate_positive_int_value(min_rows_per_group)
   validate_positive_int_value(max_rows_per_group)
 
+  source_schema <- source_data(dataset)$schema
+  # For backwards compatibility with Scanner-based writer (arrow <= 7.0.0):
+  # retain metadata from source dataset

Review Comment:
   If we had one already, a jira would be nice here, but I'm sure we'll remember this is where it's going even without it, so let'snot 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org