You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luwei16 (via GitHub)" <gi...@apache.org> on 2024/03/04 10:00:56 UTC

[PR] [fix](merge-cloud) fix full compaction core [doris]

luwei16 opened a new pull request, #31745:
URL: https://github.com/apache/doris/pull/31745

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976197725

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976226021

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976316483

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976300426

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 184200 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b9ae9cd8e6dd752799af0e6faf7df1f5f5944197, data reload: false
   
   query1	988	413	378	378
   query2	7834	2510	2465	2465
   query3	6733	301	287	287
   query4	26635	22470	22120	22120
   query5	11419	680	720	680
   query6	358	298	294	294
   query7	4685	457	443	443
   query8	316	273	261	261
   query9	8697	3415	3408	3408
   query10	560	353	365	353
   query11	17147	16737	16845	16737
   query12	188	141	138	138
   query13	1725	652	663	652
   query14	9481	7936	7716	7716
   query15	257	233	233	233
   query16	7406	447	412	412
   query17	992	662	648	648
   query18	1987	396	383	383
   query19	276	245	240	240
   query20	151	137	135	135
   query21	226	177	157	157
   query22	5050	4997	4986	4986
   query23	23633	23424	23203	23203
   query24	7211	2149	2074	2074
   query25	699	572	575	572
   query26	803	257	248	248
   query27	2423	505	489	489
   query28	3331	2848	2823	2823
   query29	1020	761	744	744
   query30	345	190	194	190
   query31	1540	790	794	790
   query32	131	97	94	94
   query33	641	384	402	384
   query34	964	649	679	649
   query35	953	860	872	860
   query36	1239	1178	1155	1155
   query37	145	119	111	111
   query38	3022	2958	2891	2891
   query39	1101	1067	1085	1067
   query40	263	180	172	172
   query41	85	84	86	84
   query42	164	168	151	151
   query43	593	574	584	574
   query44	1267	1073	1066	1066
   query45	216	209	205	205
   query46	907	805	795	795
   query47	1619	1599	1651	1599
   query48	608	532	520	520
   query49	765	476	489	476
   query50	663	551	558	551
   query51	11098	11393	11064	11064
   query52	146	147	142	142
   query53	339	335	321	321
   query54	394	353	361	353
   query55	179	136	132	132
   query56	355	346	340	340
   query57	1065	1049	1016	1016
   query58	353	352	337	337
   query59	3550	3457	3353	3353
   query60	421	440	439	439
   query61	164	160	179	160
   query62	526	407	420	407
   query63	334	325	325	325
   query64	4217	1813	1823	1813
   query65	2397	2347	2297	2297
   query66	1069	391	429	391
   query67	15020	14807	15093	14807
   query68	4829	707	737	707
   query69	680	570	584	570
   query70	1605	1573	1621	1573
   query71	487	416	460	416
   query72	2744	2298	2255	2255
   query73	680	488	496	488
   query74	7268	6971	6747	6747
   query75	3111	2693	2629	2629
   query76	2804	627	659	627
   query77	557	408	405	405
   query78	6749	6304	6182	6182
   query79	1077	768	762	762
   query80	668	614	658	614
   query81	474	264	270	264
   query82	167	137	139	137
   query83	245	232	228	228
   query84	299	128	129	128
   query85	859	505	505	505
   query86	427	424	422	422
   query87	3314	3100	3079	3079
   query88	3704	3454	3455	3454
   query89	456	418	444	418
   query90	1600	228	222	222
   query91	200	199	199	199
   query92	85	83	93	83
   query93	1024	735	728	728
   query94	651	280	278	278
   query95	600	556	537	537
   query96	640	394	391	391
   query97	2969	2777	2866	2777
   query98	342	304	307	304
   query99	860	734	711	711
   Total cold run time: 263264 ms
   Total hot run time: 184200 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976197108

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976267196

   TeamCity be ut coverage result:
    Function Coverage: 35.42% (8554/24149) 
    Line Coverage: 27.19% (69415/255285)
    Region Coverage: 26.41% (36006/136360)
    Branch Coverage: 23.24% (18391/79124)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/b9ae9cd8e6dd752799af0e6faf7df1f5f5944197_b9ae9cd8e6dd752799af0e6faf7df1f5f5944197/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #31745:
URL: https://github.com/apache/doris/pull/31745


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976203135

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976278990

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31156 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit b9ae9cd8e6dd752799af0e6faf7df1f5f5944197, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17796	4649	4496	4496
   q2	2110	222	212	212
   q3	10396	1083	1044	1044
   q4	4688	1044	1047	1044
   q5	7623	1936	1943	1936
   q6	162	120	107	107
   q7	1124	1028	1026	1026
   q8	9480	1079	1055	1055
   q9	5882	4702	4691	4691
   q10	7854	1980	1915	1915
   q11	540	315	332	315
   q12	839	396	387	387
   q13	18078	2893	2829	2829
   q14	312	283	326	283
   q15	384	371	332	332
   q16	532	490	506	490
   q17	789	332	338	332
   q18	5847	4628	4578	4578
   q19	1183	438	434	434
   q20	629	417	424	417
   q21	6594	2792	2766	2766
   q22	497	476	467	467
   Total cold run time: 103339 ms
   Total hot run time: 31156 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4649	4796	4720	4720
   q2	304	229	223	223
   q3	2101	1757	1769	1757
   q4	1527	1257	1267	1257
   q5	3110	2887	2804	2804
   q6	159	106	103	103
   q7	1807	1839	1817	1817
   q8	1867	1715	1742	1715
   q9	5300	5123	5161	5123
   q10	2591	2226	2248	2226
   q11	506	419	399	399
   q12	710	594	611	594
   q13	2949	2634	2635	2634
   q14	299	275	275	275
   q15	356	348	328	328
   q16	490	487	461	461
   q17	1133	780	794	780
   q18	5863	5339	4944	4944
   q19	1137	650	718	650
   q20	1596	1470	1405	1405
   q21	4707	4251	4228	4228
   q22	642	608	610	608
   Total cold run time: 43803 ms
   Total hot run time: 39051 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](merge-cloud) fix full compaction core [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31745:
URL: https://github.com/apache/doris/pull/31745#issuecomment-1976309759

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.09 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit b9ae9cd8e6dd752799af0e6faf7df1f5f5944197, data reload: false
   
   query1	0.05	0.04	0.03
   query2	0.11	0.04	0.04
   query3	0.26	0.07	0.06
   query4	1.59	0.09	0.09
   query5	0.51	0.51	0.50
   query6	1.56	0.99	1.01
   query7	0.02	0.02	0.02
   query8	0.06	0.04	0.05
   query9	0.70	0.67	0.66
   query10	0.73	0.69	0.73
   query11	0.21	0.16	0.15
   query12	0.19	0.15	0.15
   query13	0.52	0.49	0.45
   query14	0.74	0.72	0.71
   query15	0.93	0.94	0.87
   query16	0.39	0.40	0.40
   query17	1.17	1.22	1.21
   query18	0.32	0.30	0.29
   query19	2.16	2.04	2.08
   query20	0.03	0.02	0.02
   query21	15.38	0.93	0.93
   query22	0.61	0.60	0.59
   query23	13.68	0.61	0.62
   query24	0.57	0.19	0.19
   query25	0.05	0.05	0.04
   query26	0.19	0.19	0.20
   query27	0.05	0.04	0.04
   query28	1.26	0.75	0.75
   query29	13.11	4.69	4.82
   query30	0.89	0.81	0.78
   query31	0.87	0.40	0.41
   query32	3.22	0.40	0.40
   query33	2.41	2.41	2.32
   query34	2.22	2.19	2.21
   query35	2.18	2.21	2.17
   query36	1.02	1.04	1.01
   query37	0.08	0.06	0.06
   query38	0.05	0.05	0.04
   query39	0.03	0.02	0.03
   query40	0.20	0.16	0.17
   query41	0.08	0.03	0.03
   query42	0.04	0.03	0.03
   query43	0.04	0.04	0.04
   Total cold run time: 70.48 s
   Total hot run time: 27.09 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org