[jira] [Commented] (YARN-6593) [API] Introduce Placement Constraint object

["Wangda Tan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081175#comment-16081175 ] 

Wangda Tan commented on YARN-6593:
----------------------------------

Thanks [~kkaranasos], 

I just took a closer look at  the patch, some questions/comments (I consolidated all my above questions/comments to this one, so you only need to look at this comment and after).

1) For classes/methods are marked to be {{@public}}, it should be user-facing APIs or wire-protocol-format. I'm not sure if we should mark following classes to {{@private}}.
- Visitable/Visitor/PlacementConstraintTransformations
- PlacementConstraintToProtoConverter (Methods to transform a Constraint class to protocol should not be {{@public}}, but behavior of the process should be compatible).

And do you think we should explicitly add comment to following class to say they are marked to {{@public}} only because of wire-format compatibility?

2) Is there any reason to put PlacementConstraints in {{hadoop-yarn-common}} project instead of {{hadoop-yarn-api}}?

3) I'm not sure when you plan to use {{SingleConstraintTransformer}}/{{SpecializedConstraintTransformer}}. If you agree that they should not be user-facing, do you think we should move them to a separate JIRA while doing implementation?

4) Can we revert changes to TestContainerLaunch? 

5) In general: more javadocs need to be added for user-facing APIs, we can do this once we have a general agreement on APIs.

> [API] Introduce Placement Constraint object
> -------------------------------------------
>
>                 Key: YARN-6593
>                 URL: https://issues.apache.org/jira/browse/YARN-6593
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>             Fix For: 3.0.0-alpha3
>
>         Attachments: YARN-6593.001.patch, YARN-6593.002.patch, YARN-6593.003.patch, YARN-6593.004.patch
>
>
> This JIRA introduces an object for defining placement constraints.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org