You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/11 16:04:45 UTC

[GitHub] tardieu opened a new pull request #3177: Avoid repeated throttle check for sequences

tardieu opened a new pull request #3177: Avoid repeated throttle check for sequences
URL: https://github.com/apache/incubator-openwhisk/pull/3177
 
 
   Suggested fix for #3176.
   
   The entitlement check for reference entities in sequences (https://github.com/apache/incubator-openwhisk/blob/master/core/controller/src/main/scala/whisk/core/controller/Actions.scala#L382-L401) include checks against throttles (https://github.com/apache/incubator-openwhisk/blob/master/core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala#L221-L223) instead of simply checking for read/activate privileges. This result in the sequence being incorrectly accounted for twice (if non-empty).
   
   This patch adds the ability to check privileges without impacting throttles and uses the new option for the checking referenced entities in sequences.
   
   The added flexibility to the `Entitlement` `check` method is also necessary to correctly entitle action compositions in composer (https://github.com/tardieu/composer/tree/hybrid).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services