You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2009/10/26 11:18:27 UTC

[jira] Created: (MWAR-212) There is no good way to use @classifier@ in

There is no good way to use @classifier@ in <outputFileNameMapping>
-------------------------------------------------------------------

                 Key: MWAR-212
                 URL: http://jira.codehaus.org/browse/MWAR-212
             Project: Maven 2.x WAR Plugin
          Issue Type: Bug
    Affects Versions: 2.1-beta-1
            Reporter: Dennis Lundberg


I want to remove the version from the file names, but want to keep the classifier. This is not currently possible, because you cannot make characters optional in outputFileNameMapping.

If you use this configuration:
{code}
@{artifactId}@-@{version}@-@{classifier}@.@{extension}@
{code}
then jar files without a classifier will get an extra "-" in it.
{{maven-test-lib-1.0.jar}} becomes {{maven-test-lib-.jar}}

We want to use a configuration like this:
{code}
@{artifactId}@-@{version}@[-@{classifier}@].@{extension}@
{code}
so that the "-classifier" is only applied if there is a classifier.
{{maven-test-lib-1.0.jar}} should now become {{maven-test-lib.jar}}

To fix this I need to change the regular expressions used by RegexBasedInterpolator (from plexus interpolation) in [MappingUtils.java:66|http://svn.eu.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/util/MappingUtils.java?revision=693788&view=markup] but don't know how? Is it even possible?


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MWAR-212) There is no good way to use @classifier@ in

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MWAR-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196104#action_196104 ] 

Stephane Nicoll commented on MWAR-212:
--------------------------------------

not sure that plexus actually provides this feature out of the box. We would probably need to fix that there so that we can reuse it in others plugins.

> There is no good way to use @classifier@ in <outputFileNameMapping>
> -------------------------------------------------------------------
>
>                 Key: MWAR-212
>                 URL: http://jira.codehaus.org/browse/MWAR-212
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1-beta-1
>            Reporter: Dennis Lundberg
>
> I want to remove the version from the file names, but want to keep the classifier. This is not currently possible, because you cannot make characters optional in outputFileNameMapping.
> If you use this configuration:
> {code}
> @{artifactId}@-@{version}@-@{classifier}@.@{extension}@
> {code}
> then jar files without a classifier will get an extra "-" in it.
> {{maven-test-lib-1.0.jar}} becomes {{maven-test-lib-.jar}}
> We want to use a configuration like this:
> {code}
> @{artifactId}@-@{version}@[-@{classifier}@].@{extension}@
> {code}
> so that the "-classifier" is only applied if there is a classifier.
> {{maven-test-lib-1.0.jar}} should now become {{maven-test-lib.jar}}
> To fix this I need to change the regular expressions used by RegexBasedInterpolator (from plexus interpolation) in [MappingUtils.java:66|http://svn.eu.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/util/MappingUtils.java?revision=693788&view=markup] but don't know how? Is it even possible?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MWAR-212) Allow optional @classifier@ in

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MWAR-212:
---------------------------------

      Assignee: Dennis Lundberg
    Issue Type: Improvement  (was: Bug)
       Summary: Allow optional @classifier@ in <outputFileNameMapping>  (was: There is no good way to use @classifier@ in <outputFileNameMapping>)

> Allow optional @classifier@ in <outputFileNameMapping>
> ------------------------------------------------------
>
>                 Key: MWAR-212
>                 URL: http://jira.codehaus.org/browse/MWAR-212
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>            Reporter: Dennis Lundberg
>            Assignee: Dennis Lundberg
>
> I want to remove the version from the file names, but want to keep the classifier. This is not currently possible, because you cannot make characters optional in outputFileNameMapping.
> If you use this configuration:
> {code}
> @{artifactId}@-@{version}@-@{classifier}@.@{extension}@
> {code}
> then jar files without a classifier will get an extra "-" in it.
> {{maven-test-lib-1.0.jar}} becomes {{maven-test-lib-.jar}}
> We want to use a configuration like this:
> {code}
> @{artifactId}@-@{version}@[-@{classifier}@].@{extension}@
> {code}
> so that the "-classifier" is only applied if there is a classifier.
> {{maven-test-lib-1.0.jar}} should now become {{maven-test-lib.jar}}
> To fix this I need to change the regular expressions used by RegexBasedInterpolator (from plexus interpolation) in [MappingUtils.java:66|http://svn.eu.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/util/MappingUtils.java?revision=693788&view=markup] but don't know how? Is it even possible?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MWAR-212) Allow optional @classifier@ in

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MWAR-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MWAR-212.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1-beta-2

Fixed in [r947587|http://svn.apache.org/viewvc?view=revision&revision=947587].

> Allow optional @classifier@ in <outputFileNameMapping>
> ------------------------------------------------------
>
>                 Key: MWAR-212
>                 URL: http://jira.codehaus.org/browse/MWAR-212
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-beta-1
>            Reporter: Dennis Lundberg
>            Assignee: Dennis Lundberg
>             Fix For: 2.1-beta-2
>
>
> I want to remove the version from the file names, but want to keep the classifier. This is not currently possible, because you cannot make characters optional in outputFileNameMapping.
> If you use this configuration:
> {code}
> @{artifactId}@-@{version}@-@{classifier}@.@{extension}@
> {code}
> then jar files without a classifier will get an extra "-" in it.
> {{maven-test-lib-1.0.jar}} becomes {{maven-test-lib-.jar}}
> We want to use a configuration like this:
> {code}
> @{artifactId}@-@{version}@[-@{classifier}@].@{extension}@
> {code}
> so that the "-classifier" is only applied if there is a classifier.
> {{maven-test-lib-1.0.jar}} should now become {{maven-test-lib.jar}}
> To fix this I need to change the regular expressions used by RegexBasedInterpolator (from plexus interpolation) in [MappingUtils.java:66|http://svn.eu.apache.org/viewvc/maven/plugins/trunk/maven-war-plugin/src/main/java/org/apache/maven/plugin/war/util/MappingUtils.java?revision=693788&view=markup] but don't know how? Is it even possible?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira