[GitHub] [flink] Tartarus0zm commented on a change in pull request #17761: [FLINK-24862][Connectors / Hive]Fix user-defined hive udaf/udtf cannot be used normally in hive dialect

[GitBox <gi...@apache.org>]

Tartarus0zm commented on a change in pull request #17761:
URL: https://github.com/apache/flink/pull/17761#discussion_r755670458



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -641,7 +641,8 @@ private void validateAndPrepareFunction(CatalogFunction function)
 
             FunctionDefinition definition = ((InlineCatalogFunction) function).getDefinition();
             UserDefinedFunctionHelper.prepareInstance(config, (UserDefinedFunction) definition);
-        } else if (function.getFunctionLanguage() == FunctionLanguage.JAVA) {
+        } else if (function.getFunctionLanguage() == FunctionLanguage.JAVA

Review comment:
       Here you need to validate according to the UDxF type, because the UDxF in the Hive Metastore is validated by the Metastore




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org