You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "geoffreyclaude (via GitHub)" <gi...@apache.org> on 2025/12/08 13:43:29 UTC

[PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

geoffreyclaude opened a new pull request, #19211:
URL: https://github.com/apache/datafusion/pull/19211

   ## Which issue does this PR close?
   
   N/A - benchmark improvement
   
   ## Rationale for this change
   
   We need to measure InList performance on both StringArray (Utf8) and StringViewArray (Utf8View) to compare Arrow's string representations.
   
   ## What changes are included in this PR?
   
   Add Utf8View benchmarks for InList, refactored with generics to make adding new array types trivial.
   
   ## Are these changes tested?
   
   Benchmark-only change.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #19211:
URL: https://github.com/apache/datafusion/pull/19211


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629097559

   🤖: Benchmark completed
   
   <details><summary>Details</summary>
   <p>
   
   
   ```
   group                                          feat_in_list_utf8_benchmark            main
   -----                                          ---------------------------            ----
   in_list/Float32/list=100/nulls=0%              1.00    308.2±3.79µs        ? ?/sec  
   in_list/Float32/list=100/nulls=20%             1.00    390.9±3.16µs        ? ?/sec  
   in_list/Float32/list=3/nulls=0%                1.00     14.6±0.29µs        ? ?/sec  
   in_list/Float32/list=3/nulls=20%               1.00     19.7±0.36µs        ? ?/sec  
   in_list/Float32/list=8/nulls=0%                1.00     29.3±1.05µs        ? ?/sec  
   in_list/Float32/list=8/nulls=20%               1.00     39.2±0.11µs        ? ?/sec  
   in_list/Int32/list=100/nulls=0%                1.00   255.1±17.01µs        ? ?/sec  
   in_list/Int32/list=100/nulls=20%               1.00   325.4±15.87µs        ? ?/sec  
   in_list/Int32/list=3/nulls=0%                  1.00     13.7±0.37µs        ? ?/sec  
   in_list/Int32/list=3/nulls=20%                 1.00     17.6±0.04µs        ? ?/sec  
   in_list/Int32/list=8/nulls=0%                  1.00     25.1±0.48µs        ? ?/sec  
   in_list/Int32/list=8/nulls=20%                 1.00     34.0±0.48µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=0%/str=100         1.00    648.3±5.63µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=0%/str=12          1.00  711.7±103.46µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=0%/str=3           1.00   671.2±10.03µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=20%/str=100        1.00   602.2±15.23µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=20%/str=12         1.00    617.7±4.50µs        ? ?/sec  
   in_list/Utf8/list=100/nulls=20%/str=3          1.00    623.7±3.55µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=0%/str=100           1.00     25.6±0.25µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=0%/str=12            1.00     27.4±0.12µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=0%/str=3             1.00     26.2±0.90µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=20%/str=100          1.00     26.6±1.03µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=20%/str=12           1.00     26.6±0.08µs        ? ?/sec  
   in_list/Utf8/list=3/nulls=20%/str=3            1.00     27.5±0.56µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=0%/str=100           1.00     54.3±0.29µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=0%/str=12            1.00     59.0±3.81µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=0%/str=3             1.00     55.8±0.46µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=20%/str=100          1.00     53.2±0.37µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=20%/str=12           1.00     55.2±0.96µs        ? ?/sec  
   in_list/Utf8/list=8/nulls=20%/str=3            1.00     55.9±0.86µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=0%/str=100     1.00    480.8±6.10µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=0%/str=12      1.00    565.9±4.30µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=0%/str=3       1.00   567.7±17.28µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=20%/str=100    1.00   465.8±11.18µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=20%/str=12     1.00   516.8±17.51µs        ? ?/sec  
   in_list/Utf8View/list=100/nulls=20%/str=3      1.00    520.4±9.71µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=0%/str=100       1.00     18.6±0.20µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=0%/str=12        1.00     22.5±0.49µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=0%/str=3         1.00     22.2±0.24µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=20%/str=100      1.00     20.7±0.15µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=20%/str=12       1.00     23.3±0.36µs        ? ?/sec  
   in_list/Utf8View/list=3/nulls=20%/str=3        1.00     23.2±0.35µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=0%/str=100       1.00     39.2±0.08µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=0%/str=12        1.00     49.1±0.35µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=0%/str=3         1.00     49.2±1.71µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=20%/str=100      1.00     40.9±3.34µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=20%/str=12       1.00     46.0±0.57µs        ? ?/sec  
   in_list/Utf8View/list=8/nulls=20%/str=3        1.00     47.8±0.58µs        ? ?/sec  
   in_list_f32 (1024, 0) IN (1, 0)                                                       1.00      8.7±0.09µs        ? ?/sec
   in_list_f32 (1024, 0) IN (10, 0)                                                      1.00     34.9±1.06µs        ? ?/sec
   in_list_f32 (1024, 0) IN (100, 0)                                                     1.00    304.9±1.16µs        ? ?/sec
   in_list_f32 (1024, 0) IN (3, 0)                                                       1.00     14.8±0.73µs        ? ?/sec
   in_list_f32 (1024, 0.2) IN (1, 0)                                                     1.00     11.2±0.10µs        ? ?/sec
   in_list_f32 (1024, 0.2) IN (10, 0)                                                    1.00     47.3±0.61µs        ? ?/sec
   in_list_f32 (1024, 0.2) IN (100, 0)                                                   1.00    389.7±3.65µs        ? ?/sec
   in_list_f32 (1024, 0.2) IN (3, 0)                                                     1.00     19.6±0.33µs        ? ?/sec
   in_list_i32 (1024, 0) IN (1, 0)                                                       1.00      8.2±0.09µs        ? ?/sec
   in_list_i32 (1024, 0) IN (10, 0)                                                      1.00     29.6±0.19µs        ? ?/sec
   in_list_i32 (1024, 0) IN (100, 0)                                                     1.00    251.9±2.98µs        ? ?/sec
   in_list_i32 (1024, 0) IN (3, 0)                                                       1.00     13.6±0.22µs        ? ?/sec
   in_list_i32 (1024, 0.2) IN (1, 0)                                                     1.00     10.5±0.12µs        ? ?/sec
   in_list_i32 (1024, 0.2) IN (10, 0)                                                    1.00     35.1±0.63µs        ? ?/sec
   in_list_i32 (1024, 0.2) IN (100, 0)                                                   1.00    287.6±1.26µs        ? ?/sec
   in_list_i32 (1024, 0.2) IN (3, 0)                                                     1.00     16.5±0.13µs        ? ?/sec
   in_list_utf8(10) (1024, 0) IN (1, 0)                                                  1.00     13.1±0.31µs        ? ?/sec
   in_list_utf8(10) (1024, 0) IN (10, 0)                                                 1.00     68.6±1.01µs        ? ?/sec
   in_list_utf8(10) (1024, 0) IN (100, 0)                                                1.00   674.7±25.94µs        ? ?/sec
   in_list_utf8(10) (1024, 0) IN (3, 0)                                                  1.00     27.7±0.77µs        ? ?/sec
   in_list_utf8(10) (1024, 0.2) IN (1, 0)                                                1.00     14.3±0.20µs        ? ?/sec
   in_list_utf8(10) (1024, 0.2) IN (10, 0)                                               1.00     66.4±1.48µs        ? ?/sec
   in_list_utf8(10) (1024, 0.2) IN (100, 0)                                              1.00    623.4±6.75µs        ? ?/sec
   in_list_utf8(10) (1024, 0.2) IN (3, 0)                                                1.00     26.9±0.73µs        ? ?/sec
   in_list_utf8(20) (1024, 0) IN (1, 0)                                                  1.00     13.7±0.45µs        ? ?/sec
   in_list_utf8(20) (1024, 0) IN (10, 0)                                                 1.00     70.2±2.85µs        ? ?/sec
   in_list_utf8(20) (1024, 0) IN (100, 0)                                                1.00    676.6±4.39µs        ? ?/sec
   in_list_utf8(20) (1024, 0) IN (3, 0)                                                  1.00     27.0±1.49µs        ? ?/sec
   in_list_utf8(20) (1024, 0.2) IN (1, 0)                                                1.00     14.0±0.14µs        ? ?/sec
   in_list_utf8(20) (1024, 0.2) IN (10, 0)                                               1.00     64.8±0.26µs        ? ?/sec
   in_list_utf8(20) (1024, 0.2) IN (100, 0)                                              1.00   613.7±12.89µs        ? ?/sec
   in_list_utf8(20) (1024, 0.2) IN (3, 0)                                                1.00     26.4±0.26µs        ? ?/sec
   in_list_utf8(5) (1024, 0) IN (1, 0)                                                   1.00     13.4±0.06µs        ? ?/sec
   in_list_utf8(5) (1024, 0) IN (10, 0)                                                  1.00     67.8±1.42µs        ? ?/sec
   in_list_utf8(5) (1024, 0) IN (100, 0)                                                 1.00   691.6±11.55µs        ? ?/sec
   in_list_utf8(5) (1024, 0) IN (3, 0)                                                   1.00     26.2±0.38µs        ? ?/sec
   in_list_utf8(5) (1024, 0.2) IN (1, 0)                                                 1.00     13.9±0.07µs        ? ?/sec
   in_list_utf8(5) (1024, 0.2) IN (10, 0)                                                1.00     65.7±1.36µs        ? ?/sec
   in_list_utf8(5) (1024, 0.2) IN (100, 0)                                               1.00    614.1±3.58µs        ? ?/sec
   in_list_utf8(5) (1024, 0.2) IN (3, 0)                                                 1.00     26.7±0.46µs        ? ?/sec
   ```
   
   
   </p>
   </details>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629025258

   run benchmarks in_list
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629028245

   > run benchmarks in_list
   
   [(`sudo make me a sandwhich`)](https://xkcd.com/149/) 😆  (I added the benchmark to my allowed list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "geoffreyclaude (via GitHub)" <gi...@apache.org>.
geoffreyclaude commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3628647360

   > Thank you! I merged https://github.com/apache/datafusion/pull/19204, could you please resolve conflicts?
   
   Rebased on main
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629017020

   🤖 Hi @alamb, thanks for the request (https://github.com/apache/datafusion/pull/19211#issuecomment-3629016796).
   
   [`scrape_comments.py`](https://github.com/alamb/datafusion-benchmarking/blob/main/scripts/scrape_comments.py) only supports whitelisted benchmarks.
   - Standard: clickbench_1, clickbench_extended, clickbench_partitioned, clickbench_pushdown, tpch, tpch10, tpch_mem, tpch_mem10
   - Criterion: aggregate_query_sql, aggregate_vectorized, case_when, sql_planner
   
   Please choose one or more of these with `run benchmark <name>` or `run benchmark <name1> <name2>...`
   Unsupported benchmarks: in_list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629033218

   > 😆 did you ask AI to make your a robot version of your profile?
   
   I absolutely did


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629031015

   <img width="374" height="144" alt="image" src="https://github.com/user-attachments/assets/729e9e00-eb6a-4df2-b5f7-ffb342e16175" />
   
   😆 did you ask AI to make your a robot version of your profile?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629016796

   run benchmarks in_list


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629034419

   🤖 `./gh_compare_branch_bench.sh` [compare_branch_bench.sh](https://github.com/alamb/datafusion-benchmarking/blob/main/scripts/compare_branch_bench.sh) Running
   Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
   Comparing feat/in_list_utf8_benchmark (8a2d7d1ed03f412223ce26ed2a5e81c9f0f48f59) to 55a38d4a6da892d224a663908ff153ad5930963f [diff](https://github.com/apache/datafusion/compare/55a38d4a6da892d224a663908ff153ad5930963f..8a2d7d1ed03f412223ce26ed2a5e81c9f0f48f59)
   BENCH_NAME=in_list
   BENCH_COMMAND=cargo bench --all-features --bench in_list
   BENCH_FILTER=
   BENCH_BRANCH_NAME=feat_in_list_utf8_benchmark
   Results will be posted here when complete
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb-ghbot (via GitHub)" <gi...@apache.org>.
alamb-ghbot commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3629025580

   🤖 Hi @alamb, thanks for the request (https://github.com/apache/datafusion/pull/19211#issuecomment-3629025258).
   
   [`scrape_comments.py`](https://github.com/alamb/datafusion-benchmarking/blob/main/scripts/scrape_comments.py) only supports whitelisted benchmarks.
   - Standard: clickbench_1, clickbench_extended, clickbench_partitioned, clickbench_pushdown, tpch, tpch10, tpch_mem, tpch_mem10
   - Criterion: aggregate_query_sql, aggregate_vectorized, case_when, in_list, sql_planner
   
   Please choose one or more of these with `run benchmark <name>` or `run benchmark <name1> <name2>...`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#issuecomment-3628220829

   Thank you! I merged https://github.com/apache/datafusion/pull/19204, could you please resolve conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] bench: add dedicated Utf8View benchmarks for InList [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #19211:
URL: https://github.com/apache/datafusion/pull/19211#discussion_r2599659395


##########
datafusion/physical-expr/benches/in_list.rs:
##########
@@ -37,78 +41,129 @@ fn do_bench(c: &mut Criterion, name: &str, values: ArrayRef, exprs: &[ScalarValu
     });
 }
 
+/// Generates a random alphanumeric string of the specified length.
 fn random_string(rng: &mut StdRng, len: usize) -> String {
     let value = rng.sample_iter(&Alphanumeric).take(len).collect();
     String::from_utf8(value).unwrap()
 }
 
-fn do_benches(
-    c: &mut Criterion,
-    array_length: usize,
-    in_list_length: usize,
-    null_percent: f64,
-) {
-    let mut rng = StdRng::seed_from_u64(120320);
-    for string_length in [5, 10, 20] {
-        let values: StringArray = (0..array_length)
-            .map(|_| {
-                rng.random_bool(null_percent)
-                    .then(|| random_string(&mut rng, string_length))
-            })
-            .collect();
-
-        let in_list: Vec<_> = (0..in_list_length)
-            .map(|_| ScalarValue::from(random_string(&mut rng, string_length)))
-            .collect();
-
-        do_bench(
-            c,
-            &format!(
-                "in_list_utf8({string_length}) ({array_length}, {null_percent}) IN ({in_list_length}, 0)"
-            ),
-            Arc::new(values),
-            &in_list,
-        )
+const IN_LIST_LENGTHS: [usize; 3] = [3, 8, 100];
+const NULL_PERCENTS: [f64; 2] = [0., 0.2];
+const STRING_LENGTHS: [usize; 3] = [3, 12, 100];
+const ARRAY_LENGTH: usize = 1024;
+
+/// Returns a friendly type name for the array type.
+fn array_type_name<A: 'static>() -> &'static str {

Review Comment:
   You could potentially use https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html#display-and-fromstr
   
   So like `array.data_type().to_string()` 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org