You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Tony Foerster (Code Review)" <ge...@cloudera.org> on 2018/07/10 13:01:47 UTC
[kudu-CR] Test for backup/restore multiple tables
Tony Foerster has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10899
Change subject: Test for backup/restore multiple tables
......................................................................
Test for backup/restore multiple tables
This is a prerequisite for testing parallel backup/restore and error
handling.
- Extracted `createTable` method so it can be re-used
- Added `tableName` argument to `insertRows` so it can be re-used
Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
5 files changed, 40 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/10899/1
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Foerster <to...@phdata.io>
[kudu-CR] Test for backup/restore multiple tables
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10899 )
Change subject: Test for backup/restore multiple tables
......................................................................
Test for backup/restore multiple tables
This is a prerequisite for testing parallel backup/restore and error
handling.
- Extracted `createTable` method so it can be re-used
- Added `tableName` argument to `insertRows` so it can be re-used
Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Reviewed-on: http://gerrit.cloudera.org:8080/10899
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
5 files changed, 44 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, but someone else must approve
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 3
Gerrit-Owner: Tony Foerster <an...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
[kudu-CR] Test for backup/restore multiple tables
Posted by "Tony Foerster (Code Review)" <ge...@cloudera.org>.
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/10899 )
Change subject: Test for backup/restore multiple tables
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@97
PS1, Line 97: num
> Nit: maybe rename this to "numRows" to assign it some kind of semantic mean
Done
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala:
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala@111
PS1, Line 111: val tableOptions: CreateTableOptions = {
: val bottom = schema.newPartialRow() // Unbounded.
: val middle = schema.newPartialRow()
: middle.addInt("key", 50)
> Could you parameterize this so that createTable() can also be used to creat
I couldn't parameterize it without ending up back at the KuduClient createTable signature
kuduClient.createTable(tableName, schema, tableOptions)
I made the CreateTableOptions public and just used that.
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala@137
PS1, Line 137: targetTable: Kud
> This is now shadowing the existing class-level 'table' variable; could you
Done
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Foerster <to...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tony Foerster <to...@phdata.io>
Gerrit-Comment-Date: Thu, 12 Jul 2018 13:53:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] Test for backup/restore multiple tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10899 )
Change subject: Test for backup/restore multiple tables
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@97
PS1, Line 97: one
Nit: maybe rename this to "numRows" to assign it some kind of semantic meaning?
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
File java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala:
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala@111
PS1, Line 111: val bottom = schema.newPartialRow() // Unbounded.
: val middle = schema.newPartialRow()
: middle.addInt("key", 50)
: val top = schema.newPartialRow() // Unbounded.
Could you parameterize this so that createTable() can also be used to create the second table, on L107?
http://gerrit.cloudera.org:8080/#/c/10899/1/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala@137
PS1, Line 137: table: KuduTable
This is now shadowing the existing class-level 'table' variable; could you pick a different name here to avoid confusion?
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Foerster <to...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 21:06:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] Test for backup/restore multiple tables
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10899 )
Change subject: Test for backup/restore multiple tables
......................................................................
Patch Set 2: Code-Review+1
Will defer to Grant.
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Foerster <an...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 16:45:20 +0000
Gerrit-HasComments: No
[kudu-CR] Test for backup/restore multiple tables
Posted by "Tony Foerster (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10899
to look at the new patch set (#2).
Change subject: Test for backup/restore multiple tables
......................................................................
Test for backup/restore multiple tables
This is a prerequisite for testing parallel backup/restore and error
handling.
- Extracted `createTable` method so it can be re-used
- Added `tableName` argument to `insertRows` so it can be re-used
Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduRDDTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
5 files changed, 44 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/10899/2
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Foerster <to...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Test for backup/restore multiple tables
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10899 )
Change subject: Test for backup/restore multiple tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I439e0d1c6904395ad382e3f059846b3b03a79af4
Gerrit-Change-Number: 10899
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Foerster <an...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Thu, 12 Jul 2018 19:16:59 +0000
Gerrit-HasComments: No