You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2009/03/09 00:17:12 UTC

[jira] Created: (MRM-1111) upgrade to struts 2.1.6

upgrade to struts 2.1.6
-----------------------

                 Key: MRM-1111
                 URL: http://jira.codehaus.org/browse/MRM-1111
             Project: Archiva
          Issue Type: Bug
          Components: web application
            Reporter: Brett Porter


we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.6

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1111:
------------------------------

    Fix Version/s: 1.3

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>            Reporter: Brett Porter
>             Fix For: 1.3
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.6

Posted by "Julien HENRY (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien HENRY updated MRM-1111:
------------------------------

    Attachment: MRM-1111-jhenry.patch

This patch provides migration to Struts 2.1.6. It depends on redback and plexus-spring latest snapshot (assuming the patches provided in  REDBACK-232 are both applied).

Please review and give me your feedback.

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>            Reporter: Brett Porter
>             Fix For: 1.3
>
>         Attachments: MRM-1111-jhenry.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-1111) upgrade to struts 2.1.8.1

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter closed MRM-1111.
-----------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.4)
                   1.4-M1

most things I could find are fixed. Maybe other quirks to keep eyes open for

> upgrade to struts 2.1.8.1
> -------------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 1.4-M1
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224568#action_224568 ] 

Gwen Harold Autencio commented on MRM-1111:
-------------------------------------------

Hi Catherine,

Ah I see, ActionContextCleanUp and FilterDispatcher are deprecated since 2.1.3.
Archiva can use the same filters that is used by Continuum, since Continuum has been upgraded to struts 2.1.6.

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (MRM-1111) upgrade to struts 2.1.6

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter reassigned MRM-1111:
---------------------------------

    Assignee: Brett Porter  (was: Maria Odea Ching)

applied patch and started to fix up remaining problems. Also moved to Struts 2.1.8.1

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224790#action_224790 ] 

Maria Catherine Tan commented on MRM-1111:
------------------------------------------

Hi Stephen,

It doesn't happen to me. They still have the ".action" except for the Browse

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224017#action_224017 ] 

Maria Catherine Tan commented on MRM-1111:
------------------------------------------

Hi Gwen/Julien,

I found this: Since Struts 2.1.3, ActionContextCleanUp and FilterDispatcher are deprecated. Use StrutsPrepareFilter and StrutsExecuteFilter instead. In the API docs, it also says that it's better to use StrutsPrepareAndExecuteFilter when you don't have another filter that needs access to action context information, such as Sitemesh.
   
So from what I understand, we're supposed to use StrutsPrepareFilter and StrutsExecuteFilter instead of StrutsPrepareAndExecuteFilter or is there no difference?

{noformat}
<filter>
  <filter-name>struts-prepare</filter-name>
  <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsPrepareFilter</filter-class>
</filter>

<filter>
  <filter-name>sitemesh</filter-name>
  <filter-class>com.opensymphony.sitemesh.webapp.SiteMeshFilter</filter-class>
</filter>

<filter>
  <filter-name>struts-execute</filter-name>
  <filter-class>org.apache.struts2.dispatcher.ng.filter.StrutsExecuteFilter</filter-class>
</filter>
{noformat}

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.6

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching updated MRM-1111:
----------------------------------

    Fix Version/s:     (was: 1.3)
                   1.3.1

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>            Reporter: Brett Porter
>             Fix For: 1.3.1
>
>         Attachments: MRM-1111-jhenry.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.8.1

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-1111:
------------------------------

    Summary: upgrade to struts 2.1.8.1  (was: upgrade to struts 2.1.6)

> upgrade to struts 2.1.8.1
> -------------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221774#action_221774 ] 

Gwen Harold Autencio commented on MRM-1111:
-------------------------------------------

The page menus of archiva seems to be lost after apply the patches of redback and archiva locally.

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: MRM-1111-jhenry.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (MRM-1111) upgrade to struts 2.1.6

Posted by "Maria Odea Ching (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maria Odea Ching reassigned MRM-1111:
-------------------------------------

    Assignee: Maria Odea Ching

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>            Assignee: Maria Odea Ching
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172729#action_172729 ] 

Brett Porter commented on MRM-1111:
-----------------------------------

see also CONTINUUM-2169

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: web application
>            Reporter: Brett Porter
>             Fix For: 1.3
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.6

Posted by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gwen Harold Autencio updated MRM-1111:
--------------------------------------

    Attachment: updated-working-MRM-1111.patch

Hi,

Attaching updated working patch for the upgrade of struts to 2.1.6.
In the patch 
    * added <constant name="struts.action.extension" value="action" /> for fix of webdav
    * modified RepositoryActionMapper for fix of regression after adding struts.action.extension in struts.xml

Unit and selenium tests are already passing. This is against r949980. Thanks.


> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-1111) upgrade to struts 2.1.6

Posted by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gwen Harold Autencio updated MRM-1111:
--------------------------------------

    Attachment: initial-updated-MRM-1111.patch

Hi, 

Attaching updated patch of julien. Add fix for archiva layout and unit test for archiva-webapp.
Selenium webapp test needs to be fixed and webdav.

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Stephen Coy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224680#action_224680 ] 

Stephen Coy commented on MRM-1111:
----------------------------------

Hi there,

Do you people actually have this working? I've found that once you click on the "Browse" link, all of the left hand menu links get rendered minus their ".action" suffix.

It all seems to be working aside from this.

Remarkably I came up with much the same changes independently by the way.


> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Gwen Harold Autencio (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221912#action_221912 ] 

Gwen Harold Autencio commented on MRM-1111:
-------------------------------------------

Tried changing version of sitemesh to 2.4.2 and adding SiteMeshFilter in web.xml already displays the archiva layout.

Btw, unit tests are failing in archiva-webapp when applying patch of redback and archiva.

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: MRM-1111-jhenry.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-1111) upgrade to struts 2.1.6

Posted by "Maria Catherine Tan (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=224648#action_224648 ] 

Maria Catherine Tan commented on MRM-1111:
------------------------------------------

Hi Gwen,

Yeah, I think you really need to use StrutsPrepareFilter and StrutsExecuteFilter if you're going to remove the ActionContextCleanup :)

> upgrade to struts 2.1.6
> -----------------------
>
>                 Key: MRM-1111
>                 URL: http://jira.codehaus.org/browse/MRM-1111
>             Project: Archiva
>          Issue Type: Bug
>          Components: Web Interface
>            Reporter: Brett Porter
>             Fix For: 1.4
>
>         Attachments: initial-updated-MRM-1111.patch, MRM-1111-jhenry.patch, updated-working-MRM-1111.patch
>
>
> we are currently using 2.0.11.2

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira