You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/06/25 21:26:27 UTC
Review Request 22979: do not append and endln on cgroup write.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195
Repository: mesos-git
Description
-------
Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
Diffs
-----
src/linux/cgroups.cpp 5472eb8
Diff: https://reviews.apache.org/r/22979/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On June 25, 2014, 7:29 p.m., Vinod Kone wrote:
> > src/linux/cgroups.cpp, line 397
> > <https://reviews.apache.org/r/22979/diff/1/?file=617497#file617497line397>
> >
> > How about
> >
> > "Recent kernels will cause operations to fail if 'endl' is appended to the control file."
> >
> > I'm assuming it is backwards compatible with older kernels?
The endln was never a convention, but earlier releases never had an issue with it.
https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/ch-Using_Control_Groups.html
Newer release appear to have issue with it.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46672
-----------------------------------------------------------
On June 25, 2014, 7:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46672
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/22979/#comment82218>
How about
"Recent kernels will cause operations to fail if 'endl' is appended to the control file."
I'm assuming it is backwards compatible with older kernels?
- Vinod Kone
On June 25, 2014, 7:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 7:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46689
-----------------------------------------------------------
Ship it!
src/linux/cgroups.cpp
<https://reviews.apache.org/r/22979/#comment82229>
kill trailing white space.
p.s.: are you using our git commit hook that checks style?
- Vinod Kone
On June 25, 2014, 8:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46702
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22979]
All tests passed.
- Mesos ReviewBot
On June 25, 2014, 8:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
> On June 27, 2014, 6:18 p.m., Jie Yu wrote:
> > Tim, I removed the tailing white space for you and committed this patch.
Thanks!
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46889
-----------------------------------------------------------
On June 25, 2014, 8:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/#review46889
-----------------------------------------------------------
Ship it!
Tim, I removed the tailing white space for you and committed this patch.
- Jie Yu
On June 25, 2014, 8:26 p.m., Timothy St. Clair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22979/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 8:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1195
> https://issues.apache.org/jira/browse/MESOS-1195
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 5472eb8
>
> Diff: https://reviews.apache.org/r/22979/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy St. Clair
>
>
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/
-----------------------------------------------------------
(Updated June 25, 2014, 8:26 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195
Repository: mesos-git
Description
-------
Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
Diffs
-----
src/linux/cgroups.cpp 5472eb8
Diff: https://reviews.apache.org/r/22979/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair
Re: Review Request 22979: do not append and endln on cgroup write.
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22979/
-----------------------------------------------------------
(Updated June 25, 2014, 7:40 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
update per review
Bugs: MESOS-1195
https://issues.apache.org/jira/browse/MESOS-1195
Repository: mesos-git
Description
-------
Minor update to remove the endln appending to cgroup writes. This causes issues in later kernels, I uncovered it in rawhide.
Diffs (updated)
-----
src/linux/cgroups.cpp 5472eb8
Diff: https://reviews.apache.org/r/22979/diff/
Testing
-------
make check
Thanks,
Timothy St. Clair