[GitHub] [doris] yiguolei commented on a diff in pull request #22663: [fix](load) sharding the lock for tablet_writers map

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #22663:
URL: https://github.com/apache/doris/pull/22663#discussion_r1285838516


##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -44,7 +44,6 @@ MemTableMemoryLimiter::~MemTableMemoryLimiter() {
     DEREGISTER_HOOK_METRIC(memtable_memory_limiter_mem_consumption);
     for (auto writer : _writers) {

Review Comment:
    this loop is useless, because the writers is cleared at line 51, and all shared ptr will be cleared



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org