You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jono-morris (via GitHub)" <gi...@apache.org> on 2023/08/07 12:41:43 UTC
[GitHub] [camel] jono-morris opened a new pull request, #11027: {Camel-19712] adapt to support Junit 5.10
jono-morris opened a new pull request, #11027:
URL: https://github.com/apache/camel/pull/11027
When calling JUnit's argument converter we now need to also pass a ParameterContext from which the converter retrieves a classloader that it passes to the resolved converter class.
The Converter assumes it's converting parameters for Methods/constructors (retrieving the classloader from an Executable). However, since we convert for @Parameter fields this change passes in an Executable from the ParameterizedTemplate constructor as a standin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11027: {Camel-19712] adapt to support Junit 5.10
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1667785695
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11027: CAMEL-19712: adapt to support Junit 5.10
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1667825847
Yeah lets wait for Camel 4.1 with this upgrade.
All other frameworks like SB, Quarkus and whatnot have not upgraded and released version with JUnit 5.10.x. Its too new.
And this has global affect on all tests of Camel and end users as well that heavily use JUnit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11027: CAMEL-19712: adapt to support Junit 5.10
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1667827576
In the mean time then here is a quick one to help with
https://issues.apache.org/jira/browse/CAMEL-19627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #11027: CAMEL-19712: adapt to support Junit 5.10
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1673026058
As the `main` is open for 4.1 work, I think we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #11027: {Camel-19712] adapt to support Junit 5.10
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1667811995
@jono-morris Thanks for the contribution!!!!
@davsclaus I'm wondering if we'll want to squeeze this one in 4.0 or if we hold a bit and push it to 4.1 ... any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #11027: {Camel-19712] adapt to support Junit 5.10
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #11027:
URL: https://github.com/apache/camel/pull/11027#issuecomment-1667812517
Also, c/c @oscerd for his thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #11027: CAMEL-19712: adapt to support Junit 5.10
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #11027:
URL: https://github.com/apache/camel/pull/11027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org