You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/12/21 07:04:44 UTC

Review Request: API_refactoring: adding annotations to SSHKeyPair related commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8738/
-----------------------------------------------------------

Review request for cloudstack and Rohit Yadav.


Description
-------

API Refactoring
1. Refactoring the SSHKeyPairs related commands


Diffs
-----

  api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java b296acd 
  api/src/org/apache/cloudstack/api/command/user/ssh/DeleteSSHKeyPairCmd.java f8d2946 
  api/src/org/apache/cloudstack/api/command/user/ssh/RegisterSSHKeyPairCmd.java f31d2d8 

Diff: https://reviews.apache.org/r/8738/diff/


Testing
-------


Thanks,

Likitha Shetty


Re: Review Request: API_refactoring: adding annotations to SSHKeyPair related commands

Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8738/#review14830
-----------------------------------------------------------


Incorrect CommandType, should be UUID, for all the @Parameter annotation changes.

- Rohit Yadav


On Dec. 21, 2012, 6:04 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8738/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 6:04 a.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> API Refactoring
> 1. Refactoring the SSHKeyPairs related commands
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java b296acd 
>   api/src/org/apache/cloudstack/api/command/user/ssh/DeleteSSHKeyPairCmd.java f8d2946 
>   api/src/org/apache/cloudstack/api/command/user/ssh/RegisterSSHKeyPairCmd.java f31d2d8 
> 
> Diff: https://reviews.apache.org/r/8738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>