You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Justin Bertram <jb...@apache.com> on 2015/04/15 21:10:32 UTC
New PR build for ActiveMQ 5.x
Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
Justin
Re: New PR build for ActiveMQ 5.x
Posted by Clebert <cl...@gmail.com>.
btw. If u want a rebuild on the pr. The easiest way it to amend the commit even without any changes and push -f to your local fork. Jenkins would catch it automagically
-- Clebert Suconic typing on the iPhone.
> On Apr 16, 2015, at 13:36, artnaseef <ar...@artnaseef.com> wrote:
>
> Nice touch. Looks like it needed a little tweaking, but looks good now.
>
> I agree on the unit testing as well. We want to have some base unit tests
> to run, but I don't believe we are prepared at this time to do so.
>
>
>
>
> --
> View this message in context: http://activemq.2283324.n4.nabble.com/New-PR-build-for-ActiveMQ-5-x-tp4695015p4695092.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: New PR build for ActiveMQ 5.x
Posted by artnaseef <ar...@artnaseef.com>.
Nice touch. Looks like it needed a little tweaking, but looks good now.
I agree on the unit testing as well. We want to have some base unit tests
to run, but I don't believe we are prepared at this time to do so.
--
View this message in context: http://activemq.2283324.n4.nabble.com/New-PR-build-for-ActiveMQ-5-x-tp4695015p4695092.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: New PR build for ActiveMQ 5.x
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Justin,
good idea. We discussed about that yesterday with Hiram and Clebert.
+1
Regards
JB
On 04/15/2015 09:10 PM, Justin Bertram wrote:
> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>
> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>
>
> Justin
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: New PR build for ActiveMQ 5.x
Posted by Hiram Chirino <hi...@hiramchirino.com>.
Sweet. that should help a bit when evaluating PRs.
On Wed, Apr 15, 2015 at 3:10 PM, Justin Bertram <jb...@apache.com> wrote:
> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>
> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>
>
> Justin
--
Hiram Chirino
Engineering | Red Hat, Inc.
hchirino@redhat.com | fusesource.com | redhat.com
skype: hiramchirino | twitter: @hiramchirino
Re: New PR build for ActiveMQ 5.x
Posted by Gary Tully <ga...@gmail.com>.
it needs a target of mvn install -Dtest=0 b/c the schema is not generated
in the compile phase.
On 15 Apr 2015 23:44, "Clebert Suconic" <cl...@gmail.com> wrote:
> Any idea why this PR failed?
>
> https://github.com/apache/activemq/pull/90
>
>
> I built it here and it all passed.
>
>
> is it environmental?
>
> On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com>
> wrote:
> > Based on some feed-back from ApacheCon I just created a new job on
> Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull
> requests sent to the ActiveMQ project (i.e.
> https://github.com/apache/activemq). Ideally the job would run a small
> subset of tests to provide high-level assurance that the PR won't break
> anything significant, but at this point I don't know what those tests would
> be so this is a simple first step. If anyone would like to contribute
> something (e.g. a Maven profile) that Jenkins could invoke to perform this
> general testing for PRs feel free. I can change the job to execute any
> Maven target.
> >
> > The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
> >
> >
> > Justin
>
>
>
> --
> Clebert Suconic
> http://community.jboss.org/people/clebert.suconic@jboss.com
> http://clebertsuconic.blogspot.com
>
Re: New PR build for ActiveMQ 5.x
Posted by Mark Frazier <mm...@me.com>.
The Pioneers take the arrows!
> On Apr 15, 2015, at 3:53 PM, Clebert Suconic <cl...@gmail.com> wrote:
>
> Yeah... you were just the first to send a PR after Justin created the
> build :) it will be a good test / example.. that's why I was asking
> him.
>
> On Wed, Apr 15, 2015 at 5:49 PM, Mark Frazier <mm...@me.com> wrote:
>> Hey Clebert,
>>
>> that’s my PR and it works fine for me too.
>>
>> It seems to be missing the activemq.xsd file? But that has nothing do with my change.
>>
>> Jenkins job config?
>>
>>> On Apr 15, 2015, at 3:42 PM, Clebert Suconic <cl...@gmail.com> wrote:
>>>
>>> Any idea why this PR failed?
>>>
>>> https://github.com/apache/activemq/pull/90
>>>
>>>
>>> I built it here and it all passed.
>>>
>>>
>>> is it environmental?
>>>
>>> On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com> wrote:
>>>> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>>>>
>>>> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>>>>
>>>>
>>>> Justin
>>>
>>>
>>>
>>> --
>>> Clebert Suconic
>>> http://community.jboss.org/people/clebert.suconic@jboss.com
>>> http://clebertsuconic.blogspot.com
>>
>
>
>
> --
> Clebert Suconic
> http://community.jboss.org/people/clebert.suconic@jboss.com
> http://clebertsuconic.blogspot.com
Re: New PR build for ActiveMQ 5.x
Posted by Clebert Suconic <cl...@gmail.com>.
Yeah... you were just the first to send a PR after Justin created the
build :) it will be a good test / example.. that's why I was asking
him.
On Wed, Apr 15, 2015 at 5:49 PM, Mark Frazier <mm...@me.com> wrote:
> Hey Clebert,
>
> that’s my PR and it works fine for me too.
>
> It seems to be missing the activemq.xsd file? But that has nothing do with my change.
>
> Jenkins job config?
>
>> On Apr 15, 2015, at 3:42 PM, Clebert Suconic <cl...@gmail.com> wrote:
>>
>> Any idea why this PR failed?
>>
>> https://github.com/apache/activemq/pull/90
>>
>>
>> I built it here and it all passed.
>>
>>
>> is it environmental?
>>
>> On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com> wrote:
>>> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>>>
>>> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>>>
>>>
>>> Justin
>>
>>
>>
>> --
>> Clebert Suconic
>> http://community.jboss.org/people/clebert.suconic@jboss.com
>> http://clebertsuconic.blogspot.com
>
--
Clebert Suconic
http://community.jboss.org/people/clebert.suconic@jboss.com
http://clebertsuconic.blogspot.com
Re: New PR build for ActiveMQ 5.x
Posted by Mark Frazier <mm...@me.com>.
Hey Clebert,
that’s my PR and it works fine for me too.
It seems to be missing the activemq.xsd file? But that has nothing do with my change.
Jenkins job config?
> On Apr 15, 2015, at 3:42 PM, Clebert Suconic <cl...@gmail.com> wrote:
>
> Any idea why this PR failed?
>
> https://github.com/apache/activemq/pull/90
>
>
> I built it here and it all passed.
>
>
> is it environmental?
>
> On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com> wrote:
>> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>>
>> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>>
>>
>> Justin
>
>
>
> --
> Clebert Suconic
> http://community.jboss.org/people/clebert.suconic@jboss.com
> http://clebertsuconic.blogspot.com
Re: New PR build for ActiveMQ 5.x
Posted by Clebert Suconic <cl...@gmail.com>.
Any idea why this PR failed?
https://github.com/apache/activemq/pull/90
I built it here and it all passed.
is it environmental?
On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com> wrote:
> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>
> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>
>
> Justin
--
Clebert Suconic
http://community.jboss.org/people/clebert.suconic@jboss.com
http://clebertsuconic.blogspot.com
Re: New PR build for ActiveMQ 5.x
Posted by Clebert Suconic <cl...@gmail.com>.
Nice one!!!! so people won't be able to break the build over PRs and
go un noticed :)
On Wed, Apr 15, 2015 at 2:10 PM, Justin Bertram <jb...@apache.com> wrote:
> Based on some feed-back from ApacheCon I just created a new job on Jenkins which will do a simple compilation (i.e. 'mvn compile') for pull requests sent to the ActiveMQ project (i.e. https://github.com/apache/activemq). Ideally the job would run a small subset of tests to provide high-level assurance that the PR won't break anything significant, but at this point I don't know what those tests would be so this is a simple first step. If anyone would like to contribute something (e.g. a Maven profile) that Jenkins could invoke to perform this general testing for PRs feel free. I can change the job to execute any Maven target.
>
> The job is at https://builds.apache.org/job/ActiveMQ-PR-Build/.
>
>
> Justin
--
Clebert Suconic
http://community.jboss.org/people/clebert.suconic@jboss.com
http://clebertsuconic.blogspot.com