You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/08/18 21:16:18 UTC
Review Request 24812: Add unit test to ensure iptables stay off (if
they were initially turned off)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24812/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-6899
https://issues.apache.org/jira/browse/AMBARI-6899
Repository: ambari
Description
-------
This issue was fixed in 1.6.1 but it seems 1.6.0 did have a regression where starting the agent would turn on iptables.
We need to add a unit test to check that iptables do not turn on after agent start so that we don't have this kind of regression again.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/HostInfo.py bd0c286
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ce4604d
ambari-agent/src/test/python/ambari_agent/TestRegistration.py afd82b9
ambari-common/src/main/python/ambari_commons/__init__.py b759e76
ambari-common/src/main/python/ambari_commons/firewall.py PRE-CREATION
ambari-server/src/main/python/ambari-server.py 079b29f
ambari-server/src/test/python/TestAmbariServer.py b76e2bd
Diff: https://reviews.apache.org/r/24812/diff/
Testing
-------
Thanks,
Dmitro Lisnichenko
Re: Review Request 24812: Add unit test to ensure iptables stay off
(if they were initially turned off)
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24812/#review50970
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Aug. 18, 2014, 7:17 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24812/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 7:17 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-6899
> https://issues.apache.org/jira/browse/AMBARI-6899
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This issue was fixed in 1.6.1 but it seems 1.6.0 did have a regression where starting the agent would turn on iptables.
> We need to add a unit test to check that iptables do not turn on after agent start so that we don't have this kind of regression again.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/HostInfo.py bd0c286
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ce4604d
> ambari-agent/src/test/python/ambari_agent/TestRegistration.py afd82b9
> ambari-common/src/main/python/ambari_commons/__init__.py b759e76
> ambari-common/src/main/python/ambari_commons/firewall.py PRE-CREATION
> ambari-server/src/main/python/ambari-server.py 079b29f
> ambari-server/src/test/python/TestAmbariServer.py b76e2bd
>
> Diff: https://reviews.apache.org/r/24812/diff/
>
>
> Testing
> -------
>
> Agent python tests
>
> ----------------------------------------------------------------------
> Ran 297 tests in 8.705s
>
> OK
>
> Process finished with exit code 0
>
>
> Server python tests
> Ran 221 tests in 0.533s
>
> OK
> ----------------------------------------------------------------------
> Total run:593
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 24812: Add unit test to ensure iptables stay off
(if they were initially turned off)
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24812/
-----------------------------------------------------------
(Updated Aug. 18, 2014, 7:17 p.m.)
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-6899
https://issues.apache.org/jira/browse/AMBARI-6899
Repository: ambari
Description
-------
This issue was fixed in 1.6.1 but it seems 1.6.0 did have a regression where starting the agent would turn on iptables.
We need to add a unit test to check that iptables do not turn on after agent start so that we don't have this kind of regression again.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/HostInfo.py bd0c286
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py ce4604d
ambari-agent/src/test/python/ambari_agent/TestRegistration.py afd82b9
ambari-common/src/main/python/ambari_commons/__init__.py b759e76
ambari-common/src/main/python/ambari_commons/firewall.py PRE-CREATION
ambari-server/src/main/python/ambari-server.py 079b29f
ambari-server/src/test/python/TestAmbariServer.py b76e2bd
Diff: https://reviews.apache.org/r/24812/diff/
Testing (updated)
-------
Agent python tests
----------------------------------------------------------------------
Ran 297 tests in 8.705s
OK
Process finished with exit code 0
Server python tests
Ran 221 tests in 0.533s
OK
----------------------------------------------------------------------
Total run:593
Total errors:0
Total failures:0
OK
Thanks,
Dmitro Lisnichenko