You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/08 17:41:42 UTC

[GitHub] [pulsar] merlimat commented on issue #6606: Fix non-atomic volatile update

merlimat commented on issue #6606: Fix non-atomic volatile update
URL: https://github.com/apache/pulsar/pull/6606#issuecomment-611095545
 
 
   What is the motivation for this change? There were different specific reasons for not using volatile in these components.
   
   Volatile has a performance penalty and should only be used if strictly needed. Also, it's not a panacea that fixes all concurrency issue.
   
   As it is, I think this commit should be reverted.
   
   @yjshen @sijie 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services