You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/06/27 20:07:14 UTC
[GitHub] activemq-artemis pull request #2163: ARTEMIS-1956 move MessageCounterInfo to...
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2163
ARTEMIS-1956 move MessageCounterInfo to core-client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1956
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2163
----
commit 739ed941642bc06496f44758588ff0de45463d7f
Author: Justin Bertram <jb...@...>
Date: 2018-06-27T19:34:00Z
ARTEMIS-1956 move MessageCounterInfo to core-client
----
---
[GitHub] activemq-artemis issue #2163: ARTEMIS-1956 move MessageCounterInfo to core-c...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2163
I forgot that the client module is an explicit dependency of the server module. That satisfies my concerns. Thanks!
---
[GitHub] activemq-artemis pull request #2163: ARTEMIS-1956 move MessageCounterInfo to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2163
---
[GitHub] activemq-artemis issue #2163: ARTEMIS-1956 move MessageCounterInfo to core-c...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2163
@jbertram could you elaborate on why or what you think would break back compatibility in your change?
To me it looks ok. I guess i might have missed something.
The class stayed in the same package though a different module. And isn't the client module used in server module anyhow as such the class would be on the class path anyhow if using embedded server and somehow relied on it.
---
[GitHub] activemq-artemis issue #2163: ARTEMIS-1956 move MessageCounterInfo to core-c...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/2163
This has implications for backwards compatibility so it might be best to wait on this until the next major release. Any thoughts?
---