You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2011/09/26 17:51:26 UTC
[jira] [Created] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Replace token leaves the old node state in tact causing problems in cli
-----------------------------------------------------------------------
Key: CASSANDRA-3259
URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
Project: Cassandra
Issue Type: Bug
Environment: JVM on CentOS
Reporter: Vijay
Assignee: Vijay
Priority: Minor
in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-3259:
----------------------------------------
Affects Version/s: (was: 1.0.0)
0.8.3
Fix Version/s: 0.8.7
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3259:
-----------------------------
Attachment: (was: 0002-evict-during-replace-token-for-1.0.patch)
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch, 0002-evict-during-replace-token-for-1.0.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3259) Replace token leaves the old
node state in tact causing problems in cli
Posted by "Vijay (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118327#comment-13118327 ]
Vijay commented on CASSANDRA-3259:
----------------------------------
The problem is that, when we do the replace token we dont change the status of the old node (to removed ip or something)... hence the Node will get the State back as it is still gossiping about the replaced node. Even if removeToken() the states are not removed and hence if someone is talking about this node after (Async evict by doStatus()) this node will be added back.... hence the node will never go out of the Application State. This patch will instead will evict immediately when it sees a irrelevant host. This is simpler solution than adding another status like "remove ip". This works as expected in my tests.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3259:
--------------------------------------
Reviewer: brandon.williams
Component/s: Core
Affects Version/s: 1.0.0
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3259) Replace token leaves the old
node state in tact causing problems in cli
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118504#comment-13118504 ]
Hudson commented on CASSANDRA-3259:
-----------------------------------
Integrated in Cassandra-0.8 #352 (See [https://builds.apache.org/job/Cassandra-0.8/352/])
Evict gossip state immediately when a token is taken over.
Patch by vijay, reviewed by brandonwilliams for CASSANDRA-3259
brandonwilliams : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1177847
Files :
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/gms/Gossiper.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3259) Replace token leaves the old
node state in tact causing problems in cli
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119211#comment-13119211 ]
Sylvain Lebresne commented on CASSANDRA-3259:
---------------------------------------------
This hasn't been merged up to 1.0 yet so it should probably be (with the last changes from Vijay?), and it could probably use an entry in the changelog when doing so.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch, 0002-evict-during-replace-token-for-1.0.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3259:
-----------------------------
Attachment: 0002-evict-during-replace-token-for-1.0.patch
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch, 0002-evict-during-replace-token-for-1.0.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3259) Replace token leaves the old
node state in tact causing problems in cli
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118316#comment-13118316 ]
Brandon Williams commented on CASSANDRA-3259:
---------------------------------------------
If this is causing problems in the cli, the cli is doing something wrong, because removeEndpoint already takes it out of the Gossiper's unreachable nodes. What problem is this solving?
We do need to expire remove this endpoint but I don't think exposing evictFromMembership is the best way.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3259:
-----------------------------
Attachment: 0001-evict-replaced-node-immediately.patch
This patch fixes this issue. We can immediately delete the Application states of the token which we just replaced so that we dont gossip about it.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3259:
-----------------------------
Attachment: 0002-evict-during-replace-token-for-1.0.patch
Hi Brandon, Really sorry about extra work... i missed one change for 1.0 i was separating these 2 patches and some how i missed it....
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch, 0002-evict-during-replace-token-for-1.0.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3259) Replace token leaves the old node
state in tact causing problems in cli
Posted by "Vijay (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-3259:
-----------------------------
Attachment: 0001-evict-replaced-node-immediately-v2.patch
v2 adds abstraction to evict based on brandon's comments in IRC.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3259) Replace token leaves the old
node state in tact causing problems in cli
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120470#comment-13120470 ]
Brandon Williams commented on CASSANDRA-3259:
---------------------------------------------
Done and done.
> Replace token leaves the old node state in tact causing problems in cli
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-3259
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3259
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.8.3
> Environment: JVM on CentOS
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 0.8.7, 1.0.0
>
> Attachments: 0001-evict-replaced-node-immediately-v2.patch, 0001-evict-replaced-node-immediately.patch, 0002-evict-during-replace-token-for-1.0.patch
>
>
> in the replace token patch we dont evict the node from the Gossip which will leave the node lingering around and causes issues in cli (UNReachable nodes)
> As a part of the replace token if the token is replaced with another token we should remove the old nodes Gossip states.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira