[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6215: NIFI-9812 Skip Native Lib loading tests on ARM64

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6215:
URL: https://github.com/apache/nifi/pull/6215#discussion_r923863931


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-nar-loading-utils/src/test/java/org/apache/nifi/nar/TestNarLoader.java:
##########
@@ -33,20 +33,18 @@
 import java.util.Arrays;
 import java.util.List;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 
+
+@EnabledOnOs({ OS.MAC, OS.LINUX })
+@EnabledIfSystemProperty(named = "os.arch", matches = "x86_64")

Review Comment:
   On further review, it seems better to use `DisabledOnOs` with `OS.WINDOWS` and use `DisabledIfSystemProperty` matching `aarch64`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org