You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/08 07:39:48 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #672: FIX - Breadcrumb gone

utchoang opened a new pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672


   @rhtyd cc @svenvogel 
   Fixes #653 
   I fixed the error by saving breadcrumb data to `$store` and this is fine. But I'm not sure if it works well compared to the old logic. 
   Please check to see if it is okay. Thanks.
   ![image](https://user-images.githubusercontent.com/13766648/92447113-090cf080-f1e1-11ea-8d88-871975ec6d36.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-691779044


   closed because author closed this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689331061


   @davidjumani I think this makes it possible for the user to go back to the previous list by clicking on the breadcrumb instead of using the browser's back button.
   @rhytd Do you have any comments?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-691779044


   closed because author closed this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-691779044


   closed because @david closed this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689331061


   @davidjumani I think this makes it possible for the user to go back to the previous list by clicking on the breadcrumb instead of using the browser's back button.
   @rhtyd  Do you have any comments?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-688775985


   @davidjumani can you review this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689323743


   @utchoang It would be better to tweak the breadcrumb only if the user is in a detail view. 
   When clicking the zone while listing the instances, the breadcrumb shows /instances/zone-name
   ![Screenshot from 2020-09-09 11-14-23](https://user-images.githubusercontent.com/8244774/92559825-f224d780-f28e-11ea-8568-fbe6ae9b3807.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang closed pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
utchoang closed pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689311485


   @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689462839


   @utchoang Agreed, but it gives a wrong idea of the path, like TestZone under Instances. Would be better to add to the breadcrumb if only redirected from within a detail view (or not list view). @rhtyd Thoughts ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689311295


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #672: FIX - Breadcrumb gone

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #672:
URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689315854


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/672 (JID-3445)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org