You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/07 08:54:47 UTC
[GitHub] [flink] docete opened a new pull request #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
docete opened a new pull request #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654
…p(String, String) may yield incorrect result
## What is the purpose of the change
`SqlDateTimeUtils#toSqlTimestamp(String, String)` may yield incorrect result. Which cause:
1) cast STRING to TIMESTAMP yields incompatible result.
The original result comes from `DateTimeUtils#timestampStringToUnixDate` which supports special cases like '1999-9-10 05:20:10' or '1999-9-10'.
2) TO_TIMESTAMP yields incorrect result.
The original result comes from `SqlDateTimeUtils#toTimestamp(String, String, TimeZone)` which follows rules of completion of java.text.SimpleDateFormat
This PR fix that.
## Brief change log
- 11a9a2f Fix SqlDateTimeUtils#toSqlTimestamp(String, String) may yield incorrect result
## Verifying this change
This change added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158959829",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a9a2f6f02ef270090599849467f837baba4266 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158959829) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148)
* 5673cb5e3969a658a47ba2afd36ce0f55746e12d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158959829",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7158",
"triggerID" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"triggerType" : "PUSH"
}, {
"hash" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158989790",
"triggerID" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5673cb5e3969a658a47ba2afd36ce0f55746e12d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158989790) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158959829",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a9a2f6f02ef270090599849467f837baba4266 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158959829) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a9a2f6f02ef270090599849467f837baba4266 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158959829",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7158",
"triggerID" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"triggerType" : "PUSH"
}, {
"hash" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158989790",
"triggerID" : "5673cb5e3969a658a47ba2afd36ce0f55746e12d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a9a2f6f02ef270090599849467f837baba4266 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/158959829) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148)
* 5673cb5e3969a658a47ba2afd36ce0f55746e12d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158989790) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610265942
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 11a9a2f6f02ef270090599849467f837baba4266 (Tue Apr 07 08:57:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654#issuecomment-610269845
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
}, {
"hash" : "11a9a2f6f02ef270090599849467f837baba4266",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/158959829",
"triggerID" : "11a9a2f6f02ef270090599849467f837baba4266",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11a9a2f6f02ef270090599849467f837baba4266 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158959829) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7148)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11654: [FLINK-16632][table-planner-blink] Fix SqlDateTimeUtils#toSqlTimestam…
URL: https://github.com/apache/flink/pull/11654
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services