You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/03 08:31:37 UTC
[GitHub] [flink] chendonglin521 opened a new pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
chendonglin521 opened a new pull request #14295:
URL: https://github.com/apache/flink/pull/14295
## What is the purpose of the change
*In Web UI, Make the percent of acknowledged checkpoint more accurately*
## Brief change log
- *Make the percent of acknowledged checkpoint more accurately*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? ( no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737756527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "95b395326189c894448b3e6741bb747337ec44cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473",
"triggerID" : "95b395326189c894448b3e6741bb747337ec44cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95b395326189c894448b3e6741bb747337ec44cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737756527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "95b395326189c894448b3e6741bb747337ec44cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473",
"triggerID" : "95b395326189c894448b3e6741bb747337ec44cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95b395326189c894448b3e6741bb747337ec44cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chendonglin521 closed pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
chendonglin521 closed pull request #14295:
URL: https://github.com/apache/flink/pull/14295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737756527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "95b395326189c894448b3e6741bb747337ec44cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473",
"triggerID" : "95b395326189c894448b3e6741bb747337ec44cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95b395326189c894448b3e6741bb747337ec44cb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10473)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chendonglin521 commented on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737761730
> Is there a way to instead round down?
thank you for your reply.
I didn't find an elegant and non-rounding method. Two decimal places can ensure that the display below 10000 parallelism is accurate.
Could you give me some advice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737756527
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "95b395326189c894448b3e6741bb747337ec44cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95b395326189c894448b3e6741bb747337ec44cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 95b395326189c894448b3e6741bb747337ec44cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chendonglin521 removed a comment on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
chendonglin521 removed a comment on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737755450
> Is there a way to instead round down?
`| percent:'0.0-2'`
The percentage will be rounded to two decimal places, and the third place will be rounded.
https://www.concretepage.com/angular-2/angular-2-decimal-pipe-percent-pipe-and-currency-pipe-example#percentpipe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737750145
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 95b395326189c894448b3e6741bb747337ec44cb (Thu Dec 03 08:34:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chendonglin521 commented on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737760349
> Is there a way to instead round down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] chendonglin521 commented on pull request #14295: [FLINK-20424][Web Frontend] Make the percent of acknowledged checkpoint more accurately
Posted by GitBox <gi...@apache.org>.
chendonglin521 commented on pull request #14295:
URL: https://github.com/apache/flink/pull/14295#issuecomment-737755450
> Is there a way to instead round down?
`| percent:'0.0-2'`
The percentage will be rounded to two decimal places, and the third place will be rounded.
https://www.concretepage.com/angular-2/angular-2-decimal-pipe-percent-pipe-and-currency-pipe-example#percentpipe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org