You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/31 19:18:20 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Taragolis opened a new pull request, #25434:
URL: https://github.com/apache/airflow/pull/25434
Right now `CronDataIntervalTimetable` always run DagRun after `data_interval_end`.
This PR add optional parameter which allow run DagRun after `data_interval_start`, this might be useful for cron intervals which produce non-equal intervals such as `0 9-18 * * MON-FRI`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25434:
URL: https://github.com/apache/airflow/pull/25434#issuecomment-1200608305
I think `CronTriggerTimetable` (#23662) solves this better. We can add an additional parameter to the class toe specify how long the data interval should be. I can think of a few possibilities: none (current behaviour), a static timedelta after each cron trigger (e.g. one day), or until the next cron trigger (what this PR would achieve).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #25434:
URL: https://github.com/apache/airflow/pull/25434#issuecomment-1200854217
@uranusjr sounds reasonable!
I will postpone this PR till https://github.com/apache/airflow/pull/23662 merge into the main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25434:
URL: https://github.com/apache/airflow/pull/25434#issuecomment-1203686166
I also proposed #25503 which might be another solution to the same underlying use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #25434:
URL: https://github.com/apache/airflow/pull/25434#issuecomment-1203717575
> I also proposed #25503 which might be another solution to the same underlying use case.
I thought #23662 already cover my internal requirements.
Initially by this PR I tried just port our Custom Timetable to CronDataIntervalTimetable
So I think better close this PR. In case if additional extending required I would better open a new PR rather than keep this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis closed pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
Posted by GitBox <gi...@apache.org>.
Taragolis closed pull request #25434: wip: Ability to start CronDataIntervalTimetable's DagRun at interval start
URL: https://github.com/apache/airflow/pull/25434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org