You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Kanzhe Jiang <ka...@bigswitch.com> on 2013/02/01 02:03:55 UTC

Re: Review Request: BigSwitch VNS Networking Plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/
-----------------------------------------------------------

(Updated Feb. 1, 2013, 1:03 a.m.)


Review request for cloudstack.


Changes
-------

This is the updated patch after rebasing the dev branch.


Description
-------

This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.


Diffs (updated)
-----

  api/src/com/cloud/network/PhysicalNetwork.java a495092 
  client/pom.xml 7ebe50c 
  client/tomcatconf/commands.properties.in 755a5f2 
  client/tomcatconf/components.xml.in c41d4f4 
  cloud.spec 9f46dd6 
  debian/cloud-server.install 9cd1eeb 
  docs/en-US/Release_Notes.xml c8cc686 
  plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION 
  plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION 
  plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8 
  plugins/pom.xml c5b6e58 
  setup/db/create-schema.sql ead98a5 
  tools/apidoc/gen_toc.py 7739aea 
  ui/scripts/ui-custom/zoneWizard.js ef606e9 
  wscript_configure 3b9377b 

Diff: https://reviews.apache.org/r/9131/diff/


Testing
-------

Verify the builds: mvn clean install;
The database can be deployed;
CloudStack can be launched with the plugin modules.

JUnit tests of all api commands to a mock controller.


Thanks,

Kanzhe Jiang

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Prasanna Santhanam <Pr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15991
-----------------------------------------------------------


committed to master with 736b236

- Prasanna Santhanam


On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 1:03 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetwork.java a495092 
>   client/pom.xml 7ebe50c 
>   client/tomcatconf/commands.properties.in 755a5f2 
>   client/tomcatconf/components.xml.in c41d4f4 
>   cloud.spec 9f46dd6 
>   debian/cloud-server.install 9cd1eeb 
>   docs/en-US/Release_Notes.xml c8cc686 
>   plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8 
>   plugins/pom.xml c5b6e58 
>   setup/db/create-schema.sql ead98a5 
>   tools/apidoc/gen_toc.py 7739aea 
>   ui/scripts/ui-custom/zoneWizard.js ef606e9 
>   wscript_configure 3b9377b 
> 
> Diff: https://reviews.apache.org/r/9131/diff/
> 
> 
> Testing
> -------
> 
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
> 
> JUnit tests of all api commands to a mock controller.
> 
> 
> Thanks,
> 
> Kanzhe Jiang
> 
>

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Chiradeep Vittal <Ch...@citrix.com>.

https://issues.apache.org/jira/browse/CLOUDSTACK-1345


On 2/1/13 10:50 AM, "Kanzhe Jiang" <ka...@bigswitch.com> wrote:

>I am working through a few remaining issues, but the intention is to
>provide VNS support in 4.1.
>Definitely file a blocker bug and I will update with resolution.

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Kanzhe Jiang <ka...@bigswitch.com>.

I am working through a few remaining issues, but the intention is to
provide VNS support in 4.1.
Definitely file a blocker bug and I will update with resolution.

On Fri, Feb 1, 2013 at 10:33 AM, Chip Childers <ch...@sungard.com>wrote:

> On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal <ch...@gmail.com>
> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9131/#review16014
> > -----------------------------------------------------------
> >
> >
> > Although this has been reviewed and applied, I do have a couple more
> comments
> >  - package naming convention should be org.apache.cloudstack.*
> >  - if VNS support is not in the code yet, we should not be modifying the
> UI (or even adding the isolation method)
>
> Chiradeep - point one is covered by an existing bug (this obviously
> adds to the number of classes to deal with), but point two sounds like
> a new bug introduced with this commit.  Do you mind creating a 4.1.0
> blocker bug for it?
>
> >
> > - Chiradeep Vittal
> >
> >
> > On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/9131/
> >> -----------------------------------------------------------
> >>
> >> (Updated Feb. 1, 2013, 1:03 a.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Description
> >> -------
> >>
> >> This is the first patch for BigSwitch Network Plugin to CloudStack. The
> patch follows the design spec that can be found at
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin
> .
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   api/src/com/cloud/network/PhysicalNetwork.java a495092
> >>   client/pom.xml 7ebe50c
> >>   client/tomcatconf/commands.properties.in 755a5f2
> >>   client/tomcatconf/components.xml.in c41d4f4
> >>   cloud.spec 9f46dd6
> >>   debian/cloud-server.install 9cd1eeb
> >>   docs/en-US/Release_Notes.xml c8cc686
> >>   plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java
> PRE-CREATION
> >>
> plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java
> PRE-CREATION
> >>
> plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java
> 3bd39b8
> >>   plugins/pom.xml c5b6e58
> >>   setup/db/create-schema.sql ead98a5
> >>   tools/apidoc/gen_toc.py 7739aea
> >>   ui/scripts/ui-custom/zoneWizard.js ef606e9
> >>   wscript_configure 3b9377b
> >>
> >> Diff: https://reviews.apache.org/r/9131/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Verify the builds: mvn clean install;
> >> The database can be deployed;
> >> CloudStack can be launched with the plugin modules.
> >>
> >> JUnit tests of all api commands to a mock controller.
> >>
> >>
> >> Thanks,
> >>
> >> Kanzhe Jiang
> >>
> >>
> >
>



-- 
Kanzhe Jiang
MTS at BigSwitch

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Chip Childers <ch...@sungard.com>.

On Fri, Feb 1, 2013 at 12:40 PM, Chiradeep Vittal <ch...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/#review16014
> -----------------------------------------------------------
>
>
> Although this has been reviewed and applied, I do have a couple more comments
>  - package naming convention should be org.apache.cloudstack.*
>  - if VNS support is not in the code yet, we should not be modifying the UI (or even adding the isolation method)

Chiradeep - point one is covered by an existing bug (this obviously
adds to the number of classes to deal with), but point two sounds like
a new bug introduced with this commit.  Do you mind creating a 4.1.0
blocker bug for it?

>
> - Chiradeep Vittal
>
>
> On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9131/
>> -----------------------------------------------------------
>>
>> (Updated Feb. 1, 2013, 1:03 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Description
>> -------
>>
>> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>>
>>
>> Diffs
>> -----
>>
>>   api/src/com/cloud/network/PhysicalNetwork.java a495092
>>   client/pom.xml 7ebe50c
>>   client/tomcatconf/commands.properties.in 755a5f2
>>   client/tomcatconf/components.xml.in c41d4f4
>>   cloud.spec 9f46dd6
>>   debian/cloud-server.install 9cd1eeb
>>   docs/en-US/Release_Notes.xml c8cc686
>>   plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION
>>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION
>>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8
>>   plugins/pom.xml c5b6e58
>>   setup/db/create-schema.sql ead98a5
>>   tools/apidoc/gen_toc.py 7739aea
>>   ui/scripts/ui-custom/zoneWizard.js ef606e9
>>   wscript_configure 3b9377b
>>
>> Diff: https://reviews.apache.org/r/9131/diff/
>>
>>
>> Testing
>> -------
>>
>> Verify the builds: mvn clean install;
>> The database can be deployed;
>> CloudStack can be launched with the plugin modules.
>>
>> JUnit tests of all api commands to a mock controller.
>>
>>
>> Thanks,
>>
>> Kanzhe Jiang
>>
>>
>

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Chiradeep Vittal <ch...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review16014
-----------------------------------------------------------


Although this has been reviewed and applied, I do have a couple more comments
 - package naming convention should be org.apache.cloudstack.*
 - if VNS support is not in the code yet, we should not be modifying the UI (or even adding the isolation method)


- Chiradeep Vittal


On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 1:03 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetwork.java a495092 
>   client/pom.xml 7ebe50c 
>   client/tomcatconf/commands.properties.in 755a5f2 
>   client/tomcatconf/components.xml.in c41d4f4 
>   cloud.spec 9f46dd6 
>   debian/cloud-server.install 9cd1eeb 
>   docs/en-US/Release_Notes.xml c8cc686 
>   plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8 
>   plugins/pom.xml c5b6e58 
>   setup/db/create-schema.sql ead98a5 
>   tools/apidoc/gen_toc.py 7739aea 
>   ui/scripts/ui-custom/zoneWizard.js ef606e9 
>   wscript_configure 3b9377b 
> 
> Diff: https://reviews.apache.org/r/9131/diff/
> 
> 
> Testing
> -------
> 
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
> 
> JUnit tests of all api commands to a mock controller.
> 
> 
> Thanks,
> 
> Kanzhe Jiang
> 
>

Re: Review Request: BigSwitch VNS Networking Plugin

Posted by Murali Reddy <mu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9131/#review15990
-----------------------------------------------------------

Ship it!


Ship It!

- Murali Reddy


On Feb. 1, 2013, 1:03 a.m., Kanzhe Jiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 1:03 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetwork.java a495092 
>   client/pom.xml 7ebe50c 
>   client/tomcatconf/commands.properties.in 755a5f2 
>   client/tomcatconf/components.xml.in c41d4f4 
>   cloud.spec 9f46dd6 
>   debian/cloud-server.install 9cd1eeb 
>   docs/en-US/Release_Notes.xml c8cc686 
>   plugins/network-elements/bigswitch-vns/pom.xml PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java PRE-CREATION 
>   plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 3bd39b8 
>   plugins/pom.xml c5b6e58 
>   setup/db/create-schema.sql ead98a5 
>   tools/apidoc/gen_toc.py 7739aea 
>   ui/scripts/ui-custom/zoneWizard.js ef606e9 
>   wscript_configure 3b9377b 
> 
> Diff: https://reviews.apache.org/r/9131/diff/
> 
> 
> Testing
> -------
> 
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
> 
> JUnit tests of all api commands to a mock controller.
> 
> 
> Thanks,
> 
> Kanzhe Jiang
> 
>