You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Geoffrey Jacoby (Jira)" <ji...@apache.org> on 2020/08/31 17:15:00 UTC

[jira] [Commented] (PHOENIX-6112) Coupling of two classes only use logger

    [ https://issues.apache.org/jira/browse/PHOENIX-6112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187881#comment-17187881 ] 

Geoffrey Jacoby commented on PHOENIX-6112:
------------------------------------------

Assuming tests pass, +1. Thanks for spotting that, [~wangchao316]. 

> Coupling of two classes only use logger
> ---------------------------------------
>
>                 Key: PHOENIX-6112
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6112
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 4.x, master
>            Reporter: Chao Wang
>            Assignee: Chao Wang
>            Priority: Minor
>         Attachments: PHOENIX-6112-4.x.patch, PHOENIX-6112.master.patch, image-2020-08-28-14-48-34-990.png
>
>
> PhoenixConfigurationUtil use BaseResultIterators.logger for print log. I think this is inappropriate, Coupling of two classes. geeneral, we print log for using local class.
> !image-2020-08-28-14-48-34-990.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)