[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11362: [Feature][python] Add local dev mod runing python integate tests

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #11362:
URL: https://github.com/apache/dolphinscheduler/pull/11362#discussion_r940945119


##########
dolphinscheduler-python/pydolphinscheduler/DEVELOP.md:
##########
@@ -210,6 +213,15 @@ cd ../../
 tox -e integrate-test
 ```
 
+#### Method 2: Start the standalone server in IDEA

Review Comment:
   ```suggestion
   #### Method 2: Start Standalone Server in IntelliJ IDEA
   ```



##########
dolphinscheduler-python/pydolphinscheduler/DEVELOP.md:
##########
@@ -188,11 +188,14 @@ It would not only run unit test but also show each file coverage which cover rat
 line show you total coverage of you code. If your CI failed with coverage you could go and find some reason by
 this command output.
 
-#### Integrate Test
+### Integrate Test
 
 Integrate Test can not run when you execute command `tox -e local-ci` because it needs external environment
 including [Docker](https://docs.docker.com/get-docker/) and specific image build by [maven](https://maven.apache.org/install.html).
 Here we would show you the step to run integrate test in directory `dolphinscheduler-python/pydolphinscheduler/tests/integration`.
+There are two ways to run integrate tests.
+
+#### Method 1: Start Docker locally

Review Comment:
   ```suggestion
   #### Method 1: Launch Docker Container Locally
   ```



##########
dolphinscheduler-python/pydolphinscheduler/tox.ini:
##########
@@ -53,6 +53,13 @@ extras = test
 commands =
     python -m pytest tests/integration/
 
+[testenv:local-integrate-test]
+extras = test
+setenv =
+    skip_launch_docker = true
+commands =
+    python -m pytest tests/integration/

Review Comment:
   we can use the macro to use the existing command in L54. we already have the similar usage in L66 - L68
   ```suggestion
       {[testenv:integrate-test]commands}
   ```



##########
dolphinscheduler-python/pydolphinscheduler/tox.ini:
##########
@@ -53,6 +53,13 @@ extras = test
 commands =
     python -m pytest tests/integration/
 
+[testenv:local-integrate-test]
+extras = test
+setenv =
+    skip_launch_docker = true

Review Comment:
   Wonderful 👍 , I hadn't thought of that before 👍 



##########
dolphinscheduler-python/pydolphinscheduler/tox.ini:
##########
@@ -53,6 +53,13 @@ extras = test
 commands =
     python -m pytest tests/integration/
 
+[testenv:local-integrate-test]
+extras = test
+setenv =
+    skip_launch_docker = true

Review Comment:
   But we should still add `local-integrate-test` to L19



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org