You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/24 17:27:01 UTC
[GitHub] [spark] felixcheung commented on a change in pull request #24702:
[Minor] [Kubernetes] Added retries on the connection to the driver for k8s
felixcheung commented on a change in pull request #24702: [Minor] [Kubernetes] Added retries on the connection to the driver for k8s
URL: https://github.com/apache/spark/pull/24702#discussion_r287451124
##########
File path: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -283,7 +283,12 @@ private[spark] object CoarseGrainedExecutorBackend extends Logging {
executorConf,
new SecurityManager(executorConf),
clientMode = true)
- val driver = fetcher.setupEndpointRefByURI(arguments.driverUrl)
+
+ val driver = retry(3) {
+ fetcher.setupEndpointRefByURI(arguments.driverUrl)
+ }
Review comment:
this changes not just for k8s, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org