You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2022/04/12 12:34:00 UTC

[jira] [Resolved] (PHOENIX-6621) Consider removing PhoenixKeyValueUtil.maybeCopyCell

     [ https://issues.apache.org/jira/browse/PHOENIX-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Istvan Toth resolved PHOENIX-6621.
----------------------------------
    Resolution: Won't Do

MaybeCopyCell is required to handle ByteBuffer lifecycle issues.
Simply removing would probably cause use-after-free errors.

We're already tracking ByteBuffer-related improvements in another tickets.

> Consider removing PhoenixKeyValueUtil.maybeCopyCell
> ---------------------------------------------------
>
>                 Key: PHOENIX-6621
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6621
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Istvan Toth
>            Priority: Major
>
> We're calling PhoenixKeyValueUtil.maybeCopyCell in quite a few places.
> This copies off-heap cells to to the heap, which is expensive, and probably hurts performance.
> Try to assess the performance impact of this, and handle off-heap cells natively, if possible.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)