You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Ankur Goyal <as...@indiana.edu> on 2012/01/10 22:23:49 UTC
Review Request: Review Request for Rave-415: Display basic information of
user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/
-----------------------------------------------------------
Review request for rave and Marlon Pierce.
Summary
-------
Made a simple jsp page which displays the user profile.
Profile page has 3 tabs for the time being which on click will have a panel slide down to show information.
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1229718
trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1229718
trunk/rave-portal-resources/src/main/webapp/css/default.css 1229718
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1229718
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp PRE-CREATION
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1229718
trunk/rave-portal-resources/src/main/resources/messages.properties 1229718
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java PRE-CREATION
Diff: https://reviews.apache.org/r/3449/diff
Testing
-------
Thanks,
Ankur
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/#review4308
-----------------------------------------------------------
Thanks for the patch. See my remarks on the code. The most important thing is the missing unit test.
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java
<https://reviews.apache.org/r/3449/#comment9707>
Where is the test class for this controller?
trunk/rave-portal-resources/src/main/resources/messages.properties
<https://reviews.apache.org/r/3449/#comment9706>
Dutch translations:
Profiel van {0}
Persoonsgegevens
Voornaam:
Achternaam:
Algemene informatie
Over mij:
Burgerlijke staat: # if 'Status' means single, married etc
Contact informatie
E-mail:
trunk/rave-portal-resources/src/main/resources/messages.properties
<https://reviews.apache.org/r/3449/#comment9708>
Status as in single/married?
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp
<https://reviews.apache.org/r/3449/#comment9709>
Please add link to Rave home, widget store and for admins the link to the admin interface
- Jasha
On 2012-01-10 21:23:49, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3449/
> -----------------------------------------------------------
>
> (Updated 2012-01-10 21:23:49)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> Made a simple jsp page which displays the user profile.
> Profile page has 3 tabs for the time being which on click will have a panel slide down to show information.
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1229718
> trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1229718
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1229718
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1229718
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp PRE-CREATION
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1229718
> trunk/rave-portal-resources/src/main/resources/messages.properties 1229718
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3449/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/#review4583
-----------------------------------------------------------
Thanks Ankur for the patch. He address most of the issues raised before. Please review. Its very issue to fix my comment and i can do that if everything else looks good
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp
<https://reviews.apache.org/r/3449/#comment10212>
profile-table looks extra to me. As we are showing same profile information 2 times. Removing this will help us reduce some CSS also which is specific to profile menu
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp
<https://reviews.apache.org/r/3449/#comment10213>
Name is already displayed on top menu.
- Raminder
On 2012-01-24 20:04:12, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3449/
> -----------------------------------------------------------
>
> (Updated 2012-01-24 20:04:12)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> This is just a skeleton of profile page
> Addressed the issues mentioned and added the following:-
> -> tabs and panels for user info display
> -> horizontal list or menu to allow user to navigate to posts, about, search friends and widgets pages
> -> about jsp page allows user to view as well as edit the profile information and save the same.
> -> links on header tag to allow navigating to other pages as said
>
> Renamed user_profile.jsp to profile.jsp
> Removed profile-body,profile-footer,profile-header,profile-menu and merged them in profile.jsp
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java PRE-CREATION
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1235426
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1235426
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java PRE-CREATION
> trunk/rave-portal-resources/src/main/resources/messages.properties 1235426
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
> trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3449/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/#review4696
-----------------------------------------------------------
Ship it!
i tried to address the comments and merged with latest trunk. There are certain look and feel issue need to be addressed as separate JIRA task
- Raminder
On 2012-01-24 20:04:12, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3449/
> -----------------------------------------------------------
>
> (Updated 2012-01-24 20:04:12)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> This is just a skeleton of profile page
> Addressed the issues mentioned and added the following:-
> -> tabs and panels for user info display
> -> horizontal list or menu to allow user to navigate to posts, about, search friends and widgets pages
> -> about jsp page allows user to view as well as edit the profile information and save the same.
> -> links on header tag to allow navigating to other pages as said
>
> Renamed user_profile.jsp to profile.jsp
> Removed profile-body,profile-footer,profile-header,profile-menu and merged them in profile.jsp
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java PRE-CREATION
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1235426
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1235426
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java PRE-CREATION
> trunk/rave-portal-resources/src/main/resources/messages.properties 1235426
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
> trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3449/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/#review4582
-----------------------------------------------------------
trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js
<https://reviews.apache.org/r/3449/#comment10211>
Why we need raveProfileSpec? rave_profile.js is for profile functions
- Raminder
On 2012-01-24 20:04:12, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3449/
> -----------------------------------------------------------
>
> (Updated 2012-01-24 20:04:12)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> This is just a skeleton of profile page
> Addressed the issues mentioned and added the following:-
> -> tabs and panels for user info display
> -> horizontal list or menu to allow user to navigate to posts, about, search friends and widgets pages
> -> about jsp page allows user to view as well as edit the profile information and save the same.
> -> links on header tag to allow navigating to other pages as said
>
> Renamed user_profile.jsp to profile.jsp
> Removed profile-body,profile-footer,profile-header,profile-menu and merged them in profile.jsp
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java PRE-CREATION
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1235426
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1235426
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java PRE-CREATION
> trunk/rave-portal-resources/src/main/resources/messages.properties 1235426
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1235426
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426
> trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
> trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3449/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Ankur Goyal <as...@indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/
-----------------------------------------------------------
(Updated 2012-01-24 20:04:12.158996)
Review request for rave and Marlon Pierce.
Changes
-------
This is just a skeleton of profile page
Addressed the issues mentioned and added the following:-
-> tabs and panels for user info display
-> horizontal list or menu to allow user to navigate to posts, about, search friends and widgets pages
-> about jsp page allows user to view as well as edit the profile information and save the same.
-> links on header tag to allow navigating to other pages as said
Renamed user_profile.jsp to profile.jsp
Removed profile-body,profile-footer,profile-header,profile-menu and merged them in profile.jsp
Summary (updated)
-------
This is just a skeleton of profile page
Addressed the issues mentioned and added the following:-
-> tabs and panels for user info display
-> horizontal list or menu to allow user to navigate to posts, about, search friends and widgets pages
-> about jsp page allows user to view as well as edit the profile information and save the same.
-> links on header tag to allow navigating to other pages as said
Renamed user_profile.jsp to profile.jsp
Removed profile-body,profile-footer,profile-header,profile-menu and merged them in profile.jsp
Diffs
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java PRE-CREATION
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1235426
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1235426
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java PRE-CREATION
trunk/rave-portal-resources/src/main/resources/messages.properties 1235426
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426
trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js PRE-CREATION
Diff: https://reviews.apache.org/r/3449/diff
Testing
-------
Thanks,
Ankur
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Ankur Goyal <as...@indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/
-----------------------------------------------------------
(Updated 2012-01-24 19:59:29.410295)
Review request for rave and Marlon Pierce.
Changes
-------
This is just a skeleton of the profile page.
Addressed the issues mentioned and added the following:-
-> tabs and panels displaying user info
-> horizontal list to allow user to click on posts, search friends, about, widgets
-> about jsp page allows user to view as well as edit his information and save the same.
-> links on top of profile page to navigate to other pages as said.
Removed profile_body,profile_footer,profile_header,profile_menu and merged it in the profile jsp page.
Renamed user_profile.jsp to profile.jsp.
Summary
-------
Made a simple jsp page which displays the user profile.
Profile page has 3 tabs for the time being which on click will have a panel slide down to show information.
Diffs (updated)
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java PRE-CREATION
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ModelKeys.java 1235426
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1235426
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java PRE-CREATION
trunk/rave-portal-resources/src/main/resources/messages.properties 1235426
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/templates/base_layout.jsp 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1235426
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_about.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_friend_finder.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_posts.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_widgets.jsp PRE-CREATION
trunk/rave-portal-resources/src/main/webapp/css/default.css 1235426
trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1235426
trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
trunk/rave-portal-resources/src/test/javascript/raveProfileSpec.js PRE-CREATION
Diff: https://reviews.apache.org/r/3449/diff
Testing
-------
Thanks,
Ankur
Re: Review Request: Review Request for Rave-415: Display basic information
of user
Posted by Jesse Ciancetta <jc...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3449/#review4358
-----------------------------------------------------------
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp
<https://reviews.apache.org/r/3449/#comment9807>
If you reuse the existing "templates.user.*" tiles definition this new file would not be needed.
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp
<https://reviews.apache.org/r/3449/#comment9808>
If you reuse the existing "templates.user.*" tiles definition this new file would not be needed.
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp
<https://reviews.apache.org/r/3449/#comment9809>
If you reuse the existing "templates.user.*" tiles definition this new file would not be needed.
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp
<https://reviews.apache.org/r/3449/#comment9810>
If you reuse the existing "templates.user.*" tiles definition this new file would not be needed.
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp
<https://reviews.apache.org/r/3449/#comment9811>
I would recommend naming this profile.jsp and just using the existing "templates.user.*" tiles definition to route requests to it.
In that case you would need to embed the content you currently have in your profile_menu.jsp and profile_body.jsp files directly in this jsp. Those don't seem like pieces of content that you're likely to want to reuse elsewhere so I dont see embedding their content directly in this jsp as an issue.
The profile_header.jsp and profile_footer.jsp files would then go away as the profile page would use the same header and footer as the rest of Rave.
trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml
<https://reviews.apache.org/r/3449/#comment9805>
I don't see the need for a new tiles definition here specifically for the profile page -- it seems like the existing "templates.user.*" definition should work just fine.
- Jesse
On 2012-01-10 21:23:49, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3449/
> -----------------------------------------------------------
>
> (Updated 2012-01-10 21:23:49)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> Made a simple jsp page which displays the user profile.
> Profile page has 3 tabs for the time being which on click will have a panel slide down to show information.
>
>
> Diffs
> -----
>
> trunk/rave-portal-resources/src/main/webapp/script/rave_api.js 1229718
> trunk/rave-portal-resources/src/main/webapp/script/rave_profile.js PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/user_profile.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/tiles-defs.xml 1229718
> trunk/rave-portal-resources/src/main/webapp/css/default.css 1229718
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_header.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_menu.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1229718
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_body.jsp PRE-CREATION
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/profile_footer.jsp PRE-CREATION
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1229718
> trunk/rave-portal-resources/src/main/resources/messages.properties 1229718
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/UserInfoController.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3449/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>