You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/16 13:30:42 UTC
[GitHub] [spark] ScrapCodes opened a new pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
ScrapCodes opened a new pull request #30388:
URL: https://github.com/apache/spark/pull/30388
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Added integration test - which tries to configure a log4j.properties and checks if, it is the one pickup by the driver.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improved test coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Currently, being tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728128276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r525022152
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.integrationtest
+
+import java.io.{BufferedWriter, File, FileWriter}
+import java.net.URL
+
+import scala.io.{BufferedSource, Source}
+
+import io.fabric8.kubernetes.api.model._
+
+import org.apache.spark.internal.config
+
+private[spark] trait SparkConfPropagateSuite { k8sSuite: KubernetesSuite =>
+ import KubernetesSuite.{k8sTestTag, SPARK_PI_MAIN_CLASS}
+
+ test("Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties",
Review comment:
(Post updating the code) That is the name to keep it distinct from existing `log4j.properties`. However, when the spark conf dir is created, the default logger file name is `log4j.properties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728110160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r524439977
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
##########
@@ -43,8 +43,8 @@ import org.apache.spark.internal.config._
class KubernetesSuite extends SparkFunSuite
with BeforeAndAfterAll with BeforeAndAfter with BasicTestsSuite with SecretsTestsSuite
with PythonTestsSuite with ClientModeTestsSuite with PodTemplateSuite with PVTestsSuite
- with DepsTestsSuite with DecommissionSuite with RTestsSuite with Logging with Eventually
- with Matchers {
+ with DepsTestsSuite with DecommissionSuite with RTestsSuite with SparkConfPropagateSuite
Review comment:
Shall we put this after `BasicTestsSuite` or `SecretsTestsSuite`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728883600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r525022152
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.integrationtest
+
+import java.io.{BufferedWriter, File, FileWriter}
+import java.net.URL
+
+import scala.io.{BufferedSource, Source}
+
+import io.fabric8.kubernetes.api.model._
+
+import org.apache.spark.internal.config
+
+private[spark] trait SparkConfPropagateSuite { k8sSuite: KubernetesSuite =>
+ import KubernetesSuite.{k8sTestTag, SPARK_PI_MAIN_CLASS}
+
+ test("Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties",
Review comment:
That is the name to keep it distinct from existing `log4j.properties`. However, when the spark conf dir is created, the default logger file name is log4j.properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728041969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728041338
**[Test build #131161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131161/testReport)** for PR 30388 at commit [`3d30d1c`](https://github.com/apache/spark/commit/3d30d1c28485ef17eca0022af483edc3c1c61bea).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728883600
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728203026
:) You are hitting at the known security breaking change from Minikube side. It occurs long time ago. Please try to do the following as a workaround, @ScrapCodes . It will unblock you.
```
$ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.key" > ~/.minikube/apiserver.key
$ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.crt" > ~/.minikube/apiserver.crt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r525020917
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
##########
@@ -43,8 +43,8 @@ import org.apache.spark.internal.config._
class KubernetesSuite extends SparkFunSuite
with BeforeAndAfterAll with BeforeAndAfter with BasicTestsSuite with SecretsTestsSuite
with PythonTestsSuite with ClientModeTestsSuite with PodTemplateSuite with PVTestsSuite
- with DepsTestsSuite with DecommissionSuite with RTestsSuite with Logging with Eventually
- with Matchers {
+ with DepsTestsSuite with DecommissionSuite with RTestsSuite with SparkConfPropagateSuite
Review comment:
Yes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on a change in pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r525022152
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.integrationtest
+
+import java.io.{BufferedWriter, File, FileWriter}
+import java.net.URL
+
+import scala.io.{BufferedSource, Source}
+
+import io.fabric8.kubernetes.api.model._
+
+import org.apache.spark.internal.config
+
+private[spark] trait SparkConfPropagateSuite { k8sSuite: KubernetesSuite =>
+ import KubernetesSuite.{k8sTestTag, SPARK_PI_MAIN_CLASS}
+
+ test("Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties",
Review comment:
That is the name to keep it distinct from existing `log4j.properties`. However, when the spark conf dir is created, the default logger file name is `log4j.properties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728872384
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728110138
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35764/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728166188
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35770/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728179923
I was wondering, what I am doing wrong in my setup of minkube. I have tried 3 different versions of minikube. 1.13.1, 1.14.2, 1.15.0. All of them, failed the tests with following error.
```
KubernetesSuite:
org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite *** ABORTED ***
io.fabric8.kubernetes.client.KubernetesClientException: An error has occurred.
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:64)
at io.fabric8.kubernetes.client.KubernetesClientException.launderThrowable(KubernetesClientException.java:53)
at io.fabric8.kubernetes.client.utils.HttpClientUtils.createHttpClient(HttpClientUtils.java:234)
at io.fabric8.kubernetes.client.utils.HttpClientUtils.createHttpClient(HttpClientUtils.java:63)
at io.fabric8.kubernetes.client.BaseClient.<init>(BaseClient.java:51)
at io.fabric8.kubernetes.client.DefaultKubernetesClient.<init>(DefaultKubernetesClient.java:145)
at org.apache.spark.deploy.k8s.integrationtest.backend.minikube.Minikube$.getKubernetesClient(Minikube.scala:81)
at org.apache.spark.deploy.k8s.integrationtest.backend.minikube.MinikubeTestBackend$.initialize(MinikubeTestBackend.scala:33)
at org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.beforeAll(KubernetesSuite.scala:130)
at org.scalatest.BeforeAndAfterAll.liftedTree1$1(BeforeAndAfterAll.scala:212)
...
Cause: java.nio.file.NoSuchFileException: /home/prashant/.minikube/apiserver.crt
at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
at java.nio.file.Files.newByteChannel(Files.java:361)
at java.nio.file.Files.newByteChannel(Files.java:407)
at java.nio.file.Files.readAllBytes(Files.java:3152)
at io.fabric8.kubernetes.client.internal.CertUtils.getInputStreamFromDataOrFile(CertUtils.java:74)
at io.fabric8.kubernetes.client.internal.CertUtils.createKeyStore(CertUtils.java:244)
at io.fabric8.kubernetes.client.internal.SSLUtils.keyManagers(SSLUtils.java:128)
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728839395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728128035
**[Test build #131167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131167/testReport)** for PR 30388 at commit [`e623a0f`](https://github.com/apache/spark/commit/e623a0f04e39663502d5ec4ee028d5c1d3434174).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30388:
URL: https://github.com/apache/spark/pull/30388#discussion_r524441719
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SparkConfPropagateSuite.scala
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.integrationtest
+
+import java.io.{BufferedWriter, File, FileWriter}
+import java.net.URL
+
+import scala.io.{BufferedSource, Source}
+
+import io.fabric8.kubernetes.api.model._
+
+import org.apache.spark.internal.config
+
+private[spark] trait SparkConfPropagateSuite { k8sSuite: KubernetesSuite =>
+ import KubernetesSuite.{k8sTestTag, SPARK_PI_MAIN_CLASS}
+
+ test("Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties",
Review comment:
Ur, is the test name correct? `log-config-test-log4j.properties` seems to be used in the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728110160
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30388: [SPARK-32222][K8s][TESTS] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30388:
URL: https://github.com/apache/spark/pull/30388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728883606
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35821/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728019938
**[Test build #131161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131161/testReport)** for PR 30388 at commit [`3d30d1c`](https://github.com/apache/spark/commit/3d30d1c28485ef17eca0022af483edc3c1c61bea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728095403
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35764/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728119424
**[Test build #131167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131167/testReport)** for PR 30388 at commit [`e623a0f`](https://github.com/apache/spark/commit/e623a0f04e39663502d5ec4ee028d5c1d3434174).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728832514
**[Test build #131218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131218/testReport)** for PR 30388 at commit [`c721c51`](https://github.com/apache/spark/commit/c721c51159f727408b89c9bd17836443a7c95b58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728166210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728128276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728839890
> :) You are hitting at the known security breaking change from Minikube side. It occurs long time ago. Please try to do the following as a workaround, @ScrapCodes . It will unblock you.
>
> ```
> $ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.key" > ~/.minikube/apiserver.key
> $ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.crt" > ~/.minikube/apiserver.crt
> ```
>
> I tested it from those versions to 1.14.2 with K8s 1.19.3. It works and I believe it will work on Minikube 1.15.0, too.
Thanks a lot, this actually unblocked me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728041969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728883500
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728839202
**[Test build #131218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131218/testReport)** for PR 30388 at commit [`c721c51`](https://github.com/apache/spark/commit/c721c51159f727408b89c9bd17836443a7c95b58).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728203026
:) You are hitting at the known security breaking change from Minikube side. It occurs long time ago. Please try to do the following as a workaround, @ScrapCodes . It will unblock you.
```
$ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.key" > ~/.minikube/apiserver.key
$ minikube ssh "sudo cat /var/lib/minikube/certs/apiserver.crt" > ~/.minikube/apiserver.crt
```
I tested it from those versions to 1.14.2 with K8s 1.19.3. It works and I believe it will work on Minikube 1.15.0, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728832514
**[Test build #131218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131218/testReport)** for PR 30388 at commit [`c721c51`](https://github.com/apache/spark/commit/c721c51159f727408b89c9bd17836443a7c95b58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728146282
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35770/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30388: [WIP][SPARK-32222][K8s] Spark conf propagate - Added integration test.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728019938
**[Test build #131161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131161/testReport)** for PR 30388 at commit [`3d30d1c`](https://github.com/apache/spark/commit/3d30d1c28485ef17eca0022af483edc3c1c61bea).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728166221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35770/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30388: [WIP][SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728166210
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728839395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ScrapCodes commented on pull request #30388: [SPARK-32222][K8s] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
ScrapCodes commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-728888917
Above test failure is, due to decommission suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30388: [SPARK-32222][K8s][TESTS] Add K8s IT for conf propagation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30388:
URL: https://github.com/apache/spark/pull/30388#issuecomment-737736464
I faced the same problem here https://github.com/apache/spark/pull/30388#issuecomment-728179923 .. It should be best to document this .. It's hard to know from a glance ..
Thanks Dongjoon for workaround here https://github.com/apache/spark/pull/30388#issuecomment-728203026.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org