You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/05 20:31:53 UTC

[GitHub] [couchdb] jjrodrig opened a new pull request #3192: Proposal for removing javascript tests from main build process

jjrodrig opened a new pull request #3192:
URL: https://github.com/apache/couchdb/pull/3192


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   All the active JS tests have been ported to elixr. The current `make javascript` execution is not performing any test.
   I propose to remove it from the main build process.
   
   This PR removes `@$(MAKE) javascript` from the `check` target
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   ``` make check``` should not run the javascript test suite
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   N/A
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [X] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jjrodrig merged pull request #3192: Proposal for removing javascript tests from main build process

Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #3192:
URL: https://github.com/apache/couchdb/pull/3192


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jjrodrig commented on pull request #3192: Proposal for removing javascript tests from main build process

Posted by GitBox <gi...@apache.org>.
jjrodrig commented on pull request #3192:
URL: https://github.com/apache/couchdb/pull/3192#issuecomment-704052315


   Yes, more work is required to fully remove the JS support.  But, as an initial step, we could just stop running javascript target during the build process.
   I'll move all these commits to main and 3.x
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on pull request #3192: Proposal for removing javascript tests from main build process

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3192:
URL: https://github.com/apache/couchdb/pull/3192#issuecomment-704047152


   Also you probably want to target `main` instead of `master`, and don't forget `3.x`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on pull request #3192: Proposal for removing javascript tests from main build process

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3192:
URL: https://github.com/apache/couchdb/pull/3192#issuecomment-704045496


   Hi @jjrodrig , this isn't sufficient to fully remove JS from our build process, but if you want to commit this and leave the rest to me, +1.
   
   There's more in `configure` that needs to be dealt with, and certain things like our Windows builds will change. We will also no longer depend on `libcurl` which is an advantage in and of itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org