You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/23 15:54:24 UTC

[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #5958: updating deprecated links

mitchell852 commented on a change in pull request #5958:
URL: https://github.com/apache/trafficcontrol/pull/5958#discussion_r657246317



##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -208,7 +208,7 @@ tp_default_properties_template:
         _comment: Do you want to show a charts button for each server? If so, where
           can the charts be found? xml id will be appended to the provided url.
         show: false
-        baseUrl: "{{ tp_ts_base_url }}/dashboard/script/traffic_ops_server.js?which="
+        baseUrl: "{{ tp_ts_base_url }}/dashboard/db/server-stats?var-SERVER="

Review comment:
       yeah, i think this needs to be generic and obvious that it's generic and clear that it needs to be overriden to point to your actual dashboards. something like
   
   ```
   "{{ tp_ts_base_url }}/your-server-dashboard-url?hostname="
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org