You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by GitBox <gi...@apache.org> on 2022/05/31 06:52:00 UTC
[GitHub] [syncope] mmoayyed opened a new pull request, #348: SYNCOPE-1680: support Simple MFA for WA
mmoayyed opened a new pull request, #348:
URL: https://github.com/apache/syncope/pull/348
See https://issues.apache.org/jira/browse/SYNCOPE-1680
A few things to note:
- UI changes will be done separately once this PR is accepted.
- WA is only tasked to manage "CAS"-owned settings. Simple MFA typically requires additional configuration (such as managing the email server setup) that are handled by Spring and Spring Boot, as part of "spring.mail.*" settings. Those need to be managed separately in property files, etc.
A more precise view of the changes can be seen here: https://github.com/apache/syncope/compare/master...mmoayyed:SYNCOPE-1680?w=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] mmoayyed merged pull request #348: SYNCOPE-1680: support Simple MFA for WA
Posted by GitBox <gi...@apache.org>.
mmoayyed merged PR #348:
URL: https://github.com/apache/syncope/pull/348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #348: SYNCOPE-1680: support Simple MFA for WA
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on PR #348:
URL: https://github.com/apache/syncope/pull/348#issuecomment-1141863303
@mmoayyed a question: what is the expected value of `bypassGroovyScript`? A path or the actual script content?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] mmoayyed commented on pull request #348: SYNCOPE-1680: support Simple MFA for WA
Posted by GitBox <gi...@apache.org>.
mmoayyed commented on PR #348:
URL: https://github.com/apache/syncope/pull/348#issuecomment-1141857833
@mdisabatino Could you take a look and let me know if this works for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] mmoayyed commented on pull request #348: SYNCOPE-1680: support Simple MFA for WA
Posted by GitBox <gi...@apache.org>.
mmoayyed commented on PR #348:
URL: https://github.com/apache/syncope/pull/348#issuecomment-1141895743
Yes indeed, I was pleasantly surprised to see the UI pick up all relevant settings. Very nice!
To your question: the script setting is a path to a Groovy script that would evaluate bypass rules. It ultimately maps to this, as an example:
```
cas.authn.mfa.simple.bypass.groovy.location=file:${CAS_CONF_DIRECTORY}/mfaSimpleTrigger.groovy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a diff in pull request #348: SYNCOPE-1680: support Simple MFA for WA
Posted by GitBox <gi...@apache.org>.
ilgrosso commented on code in PR #348:
URL: https://github.com/apache/syncope/pull/348#discussion_r885380014
##########
core/persistence-jpa-json/src/test/resources/domains/MasterContent.xml:
##########
@@ -69,6 +69,8 @@ under the License.
description="JDBC auth module" jsonConf='{"_class":"org.apache.syncope.common.lib.auth.JDBCAuthModuleConf","sql":"SELECT * FROM users_table WHERE name=?", "fieldPassword": "password"}'/>
<AuthModule id="DefaultGoogleMfaAuthModule"
description="Google Mfa auth module" jsonConf='{"_class":"org.apache.syncope.common.lib.auth.GoogleMfaAuthModuleConf","codeDigits":6,"issuer":"SyncopeTest", "label":"SyncopeTest", "timeStepSize":30, "windowSize":3}'/>
+ <AuthModule id="SimpleMfaAuthModule"
Review Comment:
Just to stay aligned with others, `id` should be `DefaultSimpleMfaAuthModule`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org