You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/08/16 18:42:21 UTC
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/692
TAJO-1768: Move Tajo into Java 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo JDK8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/692.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #692
----
commit 4c2d91f13033dd84faf72058d25ee600c2314a45
Author: Hyunsik Choi <hy...@apache.org>
Date: 2015-08-16T16:38:14Z
Change the language level and the test failure.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-142515044
+1 ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/692#discussion_r40171417
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java ---
@@ -484,7 +487,7 @@ public static double getCost(LogicalNode node) {
default:
// all binary operators (join, union, except, and intersect) are handled in the above cases.
// So, we need to handle only unary nodes in default.
- cost = getCost(((UnaryNode) node).getChild());
+ cost = getCost((LogicalNode)((UnaryNode) node).getChild());
--- End diff --
Basically, It cannot be avoidable. The problem is that both getChild() and getCost() require type inference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-142497612
I rebased and reflected your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-142462050
It is ready to be reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-132086730
Can you trigger travis CI? and supporting jdk should be announced to mailing list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-142472784
I'm really waiting for this patch! I left very trivial comments.
In addition, you need to change the jdk version in BUILDING, README, and getting_started.rst.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/692#discussion_r40165600
--- Diff: tajo-plan/src/main/java/org/apache/tajo/plan/joinorder/GreedyHeuristicJoinOrderAlgorithm.java ---
@@ -484,7 +487,7 @@ public static double getCost(LogicalNode node) {
default:
// all binary operators (join, union, except, and intersect) are handled in the above cases.
// So, we need to handle only unary nodes in default.
- cost = getCost(((UnaryNode) node).getChild());
+ cost = getCost((LogicalNode)((UnaryNode) node).getChild());
--- End diff --
Duplicate cast
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/692#discussion_r40165568
--- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/Projector.java ---
@@ -20,6 +20,7 @@
import org.apache.tajo.SessionVars;
import org.apache.tajo.catalog.Schema;
+import org.apache.tajo.datum.Datum;
--- End diff --
Unused import
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1768: Move Tajo into Java 8
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/692#issuecomment-142472961
Thank you for your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---