[GitHub] [solr] risdenk commented on a change in pull request #526: SOLR-15916: Remove dist from distribution.

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #526:
URL: https://github.com/apache/solr/pull/526#discussion_r785187780



##########
File path: solr/solr-ref-guide/src/jdbc-dbvisualizer.adoc
##########
@@ -22,8 +22,8 @@ For DbVisualizer, you will need to create a new driver for Solr using the DbVisu
 This will add several SolrJ client .jars to the DbVisualizer classpath.
 The files required are:
 
-* all .jars found in `$SOLR_HOME/dist/solrj-lib`
-* the SolrJ .jar found at `$SOLR_HOME/dist/solr-solrj-<version>.jar`
+* all .jars found in `$SOLR_HOME/server/solr-webapp/webapp/WEB-INF/lib/\*` and `$SOLR_HOME/server/lib/ext/*`

Review comment:
       I probably initially wrote these docs (or at least contributed over time) and at the time it was almost all jars in those places. It was easier to say "use all" instead of trying to list specific ones to pull out.
   
   It would be 10000000x better to have a single jdbc jar with everything included - SOLR-8680 was filed years ago to try to address this. I couldn't figure out a good way to do it with ant, but it might be easier now with gradle and the improved dependency management logic (ie: ability to include transitive). I haven't looked recently.
   
   There are probably a ton of jars that aren't needed, but requires testing to figure out the minimal set or potentially using gradle dependency management to simplify.  The ant build made it VERY hard to try to pull out specific dependencies. If gradle can build a dependency tree to see what gets pulled in - it would be a lot easier.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org